Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include jQuery as dependency #160

Closed
humitos opened this issue Nov 23, 2021 · 3 comments · Fixed by #241
Closed

Include jQuery as dependency #160

humitos opened this issue Nov 23, 2021 · 3 comments · Fixed by #241
Assignees
@humitos
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code

Comments

@humitos
Copy link
Member

humitos commented Nov 23, 2021

It seems that Sphinx will remove jQuery in the future releases, see sphinx-doc/sphinx#7405

When that happens, we will need to vendor our own jQuery version because tooltipster requires it.
@humitos humitos added Improvement Minor improvement to code Accepted Accepted issue on our roadmap labels Nov 23, 2021
@nienn
Copy link

nienn commented Nov 24, 2021 •
edited
Loading

Related issue: readthedocs/sphinx_rtd_theme#1253

@humitos
Copy link
Member Author

humitos commented May 30, 2022

The removal will happen on 6.0: sphinx-doc/sphinx#10070

@humitos humitos moved this to Planned in 📍Roadmap Jun 21, 2022
@humitos humitos self-assigned this Jun 21, 2022
@ericholscher ericholscher assigned stsewd and unassigned stsewd Jun 21, 2022
@humitos humitos moved this from Planned to In progress in 📍Roadmap Jun 23, 2022
@humitos humitos mentioned this issue Jun 27, 2022
Closed
@humitos
Copy link
Member Author

humitos commented Aug 29, 2022

This will be managed by the sphinx-jquery extension we plan to create in the near future. I'm removing it from my current sprint because I'm not working on it for now.

@humitos humitos moved this from In progress to Planned in 📍Roadmap Aug 29, 2022
This was referenced Oct 17, 2022
Closed
Merged
@humitos humitos mentioned this issue Oct 24, 2022
Merged
Repository owner moved this from Planned to Done in 📍Roadmap Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@humitos humitos

Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
📍Roadmap
Archived in project
Milestone
No milestone
3 participants
@humitos @nienn @stsewd