From 6c15a769bae1263bf77d8015c27902e0fb5c6fcc Mon Sep 17 00:00:00 2001
From: Eric Holscher <eric@ericholscher.com>
Date: Tue, 5 Mar 2019 18:14:27 -0300
Subject: [PATCH 1/5] Remove the dropdown next to "View Docs"

This removes it from the:

* User profile page
* Homepage

This caused a significant DB load when a project has a large number of versions,
and is almost certainly never used by users.
They can click the project to get a specific version.
---
 readthedocs/templates/core/project_list_detailed.html | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/readthedocs/templates/core/project_list_detailed.html b/readthedocs/templates/core/project_list_detailed.html
index 1eb24632650..b099b1396af 100644
--- a/readthedocs/templates/core/project_list_detailed.html
+++ b/readthedocs/templates/core/project_list_detailed.html
@@ -33,14 +33,7 @@
     <span class="dropdown" style="position:absolute; right:0px; top:0px;">
       <span>
           <a href="{{ project.get_docs_url }}">{% trans "View Docs" %}</a>
-        <a href="#">&#x25BC;</a>
       </span>
-      <ul>
-          <li><input type="search" placeholder="{% trans "Search" %}&hellip;" /></li>
-          {% for version in project.ordered_active_versions reversed %}
-              <li><a href="{{ version.get_absolute_url }}">{{ version.slug }}</a></li>
-          {% endfor %}
-      </ul>
     </span>
     {% else %}
     <ul class="module-item-menu">

From 9a36ae9dc07f2653b71e1aed2ba5eee2e57d74f0 Mon Sep 17 00:00:00 2001
From: Eric Holscher <eric@ericholscher.com>
Date: Tue, 5 Mar 2019 18:16:34 -0300
Subject: [PATCH 2/5] More places

---
 readthedocs/templates/core/project_list_featured.html | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/readthedocs/templates/core/project_list_featured.html b/readthedocs/templates/core/project_list_featured.html
index 9af11212fec..fc1e09090c7 100644
--- a/readthedocs/templates/core/project_list_featured.html
+++ b/readthedocs/templates/core/project_list_featured.html
@@ -11,14 +11,7 @@
     <span class="dropdown" style="position:absolute; right:0px; top:0px;">
       <span>
           <a href="{{ project.get_docs_url }}">{% trans "View Docs" %}</a>
-        <a href="#">&#x25BC;</a>
       </span>
-      <ul>
-          <li><input type="search" placeholder="{% trans "Search" %}&hellip;" /></li>
-          {% for version in project.ordered_active_versions reversed %}
-              <li><a href="{{ version.get_absolute_url }}">{{ version.slug }}</a></li>
-          {% endfor %}
-      </ul>
     </span>
     {% else %}
     <ul class="module-item-menu">

From d9ee036fea9fa67c00e75bc57356bd024c9a63aa Mon Sep 17 00:00:00 2001
From: Eric Holscher <eric@ericholscher.com>
Date: Tue, 5 Mar 2019 18:20:57 -0300
Subject: [PATCH 3/5] Use a right arrow to unbreak styles

---
 readthedocs/templates/core/project_list_detailed.html | 1 +
 readthedocs/templates/core/project_list_featured.html | 1 +
 2 files changed, 2 insertions(+)

diff --git a/readthedocs/templates/core/project_list_detailed.html b/readthedocs/templates/core/project_list_detailed.html
index b099b1396af..d66fac8a0db 100644
--- a/readthedocs/templates/core/project_list_detailed.html
+++ b/readthedocs/templates/core/project_list_detailed.html
@@ -33,6 +33,7 @@
     <span class="dropdown" style="position:absolute; right:0px; top:0px;">
       <span>
           <a href="{{ project.get_docs_url }}">{% trans "View Docs" %}</a>
+          <a href="#">&#x25B6;</a>
       </span>
     </span>
     {% else %}
diff --git a/readthedocs/templates/core/project_list_featured.html b/readthedocs/templates/core/project_list_featured.html
index fc1e09090c7..e44f9c35ce1 100644
--- a/readthedocs/templates/core/project_list_featured.html
+++ b/readthedocs/templates/core/project_list_featured.html
@@ -11,6 +11,7 @@
     <span class="dropdown" style="position:absolute; right:0px; top:0px;">
       <span>
           <a href="{{ project.get_docs_url }}">{% trans "View Docs" %}</a>
+        <a href="#">&#x25B6;</a>
       </span>
     </span>
     {% else %}

From 99191ebb5995dddf9c9dec26cbf649b24612de0e Mon Sep 17 00:00:00 2001
From: Santos Gallegos <santos_g@outlook.com>
Date: Tue, 5 Mar 2019 17:27:28 -0500
Subject: [PATCH 4/5] Remove arrows

---
 .../templates/core/project_list_detailed.html   | 17 +++++++----------
 .../templates/core/project_list_featured.html   | 17 +++++++----------
 2 files changed, 14 insertions(+), 20 deletions(-)

diff --git a/readthedocs/templates/core/project_list_detailed.html b/readthedocs/templates/core/project_list_detailed.html
index d66fac8a0db..d6af7a72e4b 100644
--- a/readthedocs/templates/core/project_list_detailed.html
+++ b/readthedocs/templates/core/project_list_detailed.html
@@ -29,18 +29,15 @@
     <span class="right-menu quiet">{% trans "No builds" %}</span>
     {% endif %}
 
-    {% if project.has_good_build %}
-    <span class="dropdown" style="position:absolute; right:0px; top:0px;">
-      <span>
-          <a href="{{ project.get_docs_url }}">{% trans "View Docs" %}</a>
-          <a href="#">&#x25B6;</a>
-      </span>
-    </span>
-    {% else %}
     <ul class="module-item-menu">
-      <li><a href="{{ project.get_builds_url }}">{% trans "No Docs" %}</a></li>
+      <li>
+        {% if project.has_good_build %}
+          <a href="{{ project.get_docs_url }}">{% trans "View Docs" %}
+          {% else %}
+            <a href="{{ project.get_builds_url }}">{% trans "No Docs" %}</a>
+          {% endif %}
+      </li>
     </ul>
-    {% endif %}
 
 
   </li>
diff --git a/readthedocs/templates/core/project_list_featured.html b/readthedocs/templates/core/project_list_featured.html
index e44f9c35ce1..8d10d28c9e8 100644
--- a/readthedocs/templates/core/project_list_featured.html
+++ b/readthedocs/templates/core/project_list_featured.html
@@ -7,18 +7,15 @@
         <a href="{{ user.get_absolute_url }}" class="quiet">({{ user }})</a>
     {% endfor %}
 
-    {% if project.has_good_build %}
-    <span class="dropdown" style="position:absolute; right:0px; top:0px;">
-      <span>
-          <a href="{{ project.get_docs_url }}">{% trans "View Docs" %}</a>
-        <a href="#">&#x25B6;</a>
-      </span>
-    </span>
-    {% else %}
     <ul class="module-item-menu">
-      <li><a href="{{ project.get_builds_url }}">{% trans "No Docs" %}</a></li>
+      <li>
+        {% if project.has_good_build %}
+          <a href="{{ project.get_docs_url }}">{% trans "View Docs" %}</a>
+        {% else %}
+          <a href="{{ project.get_builds_url }}">{% trans "No Docs" %}</a>
+        {% endif %}
+      </li>
     </ul>
-    {% endif %}
 
   </li>
 

From 5a1e667e8846b11c3ef994ffeedeec07557ff524 Mon Sep 17 00:00:00 2001
From: Santos Gallegos <santos_g@outlook.com>
Date: Tue, 5 Mar 2019 18:22:52 -0500
Subject: [PATCH 5/5] Fix ifelse

---
 readthedocs/templates/core/project_list_detailed.html | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/readthedocs/templates/core/project_list_detailed.html b/readthedocs/templates/core/project_list_detailed.html
index d6af7a72e4b..a39c51ef8a2 100644
--- a/readthedocs/templates/core/project_list_detailed.html
+++ b/readthedocs/templates/core/project_list_detailed.html
@@ -32,10 +32,10 @@
     <ul class="module-item-menu">
       <li>
         {% if project.has_good_build %}
-          <a href="{{ project.get_docs_url }}">{% trans "View Docs" %}
-          {% else %}
-            <a href="{{ project.get_builds_url }}">{% trans "No Docs" %}</a>
-          {% endif %}
+          <a href="{{ project.get_docs_url }}">{% trans "View Docs" %}</a>
+        {% else %}
+          <a href="{{ project.get_builds_url }}">{% trans "No Docs" %}</a>
+        {% endif %}
       </li>
     </ul>