Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless path from output build commands #7004

Closed
humitos opened this issue Apr 30, 2020 · 5 comments
Closed

Remove useless path from output build commands #7004

humitos opened this issue Apr 30, 2020 · 5 comments
Labels
Accepted Accepted issue on our roadmap Design Design or UX/UI related

Comments

@humitos
Copy link
Member

humitos commented Apr 30, 2020

Instead of

 /home/docs/checkouts/readthedocs.org/user_builds/godot/envs/latest/bin/python -m pip install --exists-action=w --no-cache-dir -r requirements.txt 

Screenshot_2020-04-30_11-00-38

We should have these commands listed as

python -m pip install --exists-action=w --no-cache-dir -r requirements.txt 

Reference #6992 (comment)

@humitos humitos added Design Design or UX/UI related Accepted Accepted issue on our roadmap labels Apr 30, 2020
@humitos humitos added this to the Build output page milestone Apr 30, 2020
@ericholscher
Copy link
Member

@agjohnson if there is an easy way to backport this, I'd love to ship it next week. It's bothered me for a long time :)

@stsewd
Copy link
Member

stsewd commented May 7, 2020

We can also edit our commands to use the correct cwd when executing commands, so we only pass the relative path.

@agjohnson
Copy link
Contributor

I did this display side in a hacky way, it's nothing reusable. Our solution would need to work for both our database and cold storage backed data, so it might make sense to continue doing this display side. Either way, I'm investing my time on the new templates, I don't want to worry about backporting any work into our current UI.

@agjohnson
Copy link
Contributor

Basically what I did here was highly naive:

const re_command_trim = /(\/usr\/src\/app|\/home\/docs)\/checkouts\/readthedocs.org\/user_builds\/[^\/]+\/[^\/]+\/[^\/]+\//g;
let command = build_command.command.replace(re_command_trim, "");

This covers both build cold storage and database entries, so unfortunately seems like the best place to do this? Anyways, this is already done in the new UI, and I'm not sure I have much to add to the hack above. We could remove the path from the commands as we are saving them if we want, but this hack will have to remain in place because of old data.

@humitos
Copy link
Member Author

humitos commented Jul 24, 2023

This was done at #9831

@humitos humitos closed this as completed Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Design Design or UX/UI related
Projects
None yet
Development

No branches or pull requests

4 participants