Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all tests pass with django_dynamic_fixture 3.x #6886

Closed
stsewd opened this issue Apr 9, 2020 · 4 comments · Fixed by #7073
Closed

Make all tests pass with django_dynamic_fixture 3.x #6886

stsewd opened this issue Apr 9, 2020 · 4 comments · Fixed by #7073
Labels
Accepted Accepted issue on our roadmap Good First Issue Good for new contributors Improvement Minor improvement to code

Comments

@stsewd
Copy link
Member

stsewd commented Apr 9, 2020

When updated ddf in #6885, a lot of tests started to fail... the reason? We are creating models with fields they don't have.. ddf is more strict now, that's good. I didn't want to expend more time in #6885 so I'm creating this issue to keep track of that.

@stsewd stsewd added Good First Issue Good for new contributors Improvement Minor improvement to code Accepted Accepted issue on our roadmap labels Apr 9, 2020
@santos22
Copy link
Contributor

santos22 commented May 5, 2020

What's the reason these are failing? Are they all failing for the same reason? I tried running some tests locally and the following was what I got:

tox -e py37 readthedocs/rtd_tests/tests/test_project_forms.py

Screen Shot 2020-05-05 at 10 42 37 AM

This might be because I'm using py37.

@stsewd
Copy link
Member Author

stsewd commented May 5, 2020

@santos22 we are creating some models with invalid data, django dynamic fixture used to just ignore that, but with the new version it raises an exception. The codebase should run with python 3.6.

You can see some corrections in https://github.com/readthedocs/readthedocs.org/pull/6885/files

@santos22
Copy link
Contributor

santos22 commented May 5, 2020

Sounds good. I'll try to get the codebase running with Python 3.6 and fix some of these tests.

@santos22
Copy link
Contributor

Managed to get Python 3.6 running on my Windows machine. Working on making the tests pass 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Good First Issue Good for new contributors Improvement Minor improvement to code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants