Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search index not updated after renaming/moving of a page #6069

Closed
dojutsu-user opened this issue Aug 13, 2019 · 12 comments · Fixed by #6298
Closed

Search index not updated after renaming/moving of a page #6069

dojutsu-user opened this issue Aug 13, 2019 · 12 comments · Fixed by #6298
Labels
Bug A bug Needed: replication Bug replication is required

Comments

@dojutsu-user
Copy link
Member

#5845 renames APIv3 Design Document from Design of APIv3 to APIv3 Design Document but the search results still contains both results.

Related link: https://docs.readthedocs.io/en/latest/index.html?rtd_search=apiv3

Screenshot from 2019-08-13 21-23-29

@dojutsu-user dojutsu-user added Bug A bug Needed: replication Bug replication is required labels Aug 13, 2019
@stsewd
Copy link
Member

stsewd commented Aug 14, 2019

There is this error on sentry, maybe related to this issue

update or delete on table "projects_importedfile" violates foreign key constraint "sphinx_domains_sphin_html_file_id_a0307e9f_fk_projects_" on table "sphinx_domains_sphinxdomain"

It happens here

# Delete ImportedFiles objects (including HTMLFiles)
# from the previous build of the version.
(
ImportedFile.objects
.filter(project=version.project, version=version)
.exclude(build=build)
.delete()
)

https://sentry.io/organizations/read-the-docs/issues/1144425753/?project=148442&query=is%3Aunresolved&statsPeriod=14d

@hiddeco
Copy link

hiddeco commented Aug 15, 2019

Not sure if this is related, but for https://docs.fluxcd.io, we also notice that renamed files and files removed from git aren't removed from the index.

E.g. first result for this search: https://docs.fluxcd.io/en/latest/search.html?q=ignore&check_keywords=yes&area=default

@dojutsu-user
Copy link
Member Author

dojutsu-user commented Aug 16, 2019

@hiddeco
I think wiping the version and then rebuilding the docs should fix the problem.
You can find the steps for it here: https://docs.readthedocs.io/en/stable/guides/wipe-environment.html

@hiddeco
Copy link

hiddeco commented Aug 21, 2019

@dojutsu-user already did this before I commented, without any effect.

@jcampbell
Copy link

Thanks @stsewd for flagging this still-open issue. We're observing this on the great expectations docs (https://great-expectations.readthedocs.io/en/latest/). Searching for a moved page shows both the new (working) and broken link. I have tried wiping and rebuilding to no effect.

@Flid
Copy link

Flid commented Oct 22, 2019

Also affecting https://kedro.readthedocs.io, most of the search queries show the broken links first, since we've moved some stuff around.

@Flid
Copy link

Flid commented Oct 28, 2019

@dojutsu-user Can you please confirm if the bug is actually fixed for you?
Nothing changed for our project.

@humitos
Copy link
Member

humitos commented Oct 28, 2019

It's fixed but it's not deployed yet.

@madelyngreyes
Copy link

Do we have a status on the deployment of the possible fix by chance?

@stsewd
Copy link
Member

stsewd commented Dec 2, 2019

@madelyngreyes it's already deployed. If you still have this problem, you should try rebuilding the version.

@Flid
Copy link

Flid commented Dec 3, 2019

Our issue has been fixed after the release. Thank you!

@madelyngreyes
Copy link

madelyngreyes commented Dec 3, 2019

The issue was fixed on our end as well, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug Needed: replication Bug replication is required
Projects
None yet
7 participants