New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove possibel unused constant #5422

Closed

stsewd opened this issue Mar 8, 2019 · 1 comment · Fixed by #5424

Labels

Good First Issue Improvement

Milestone

Member

stsewd commented Mar 8, 2019

At first sight looks like isn't used anymore after #5383

https://github.com/rtfd/readthedocs.org/blob/78c34c904b347110b2cd545b4b5a80ed526590f7/readthedocs/core/models.py#L13-L13

We should still double check and make sure tests are passing after the removal.

stsewd added Good First Issue Improvement labels

stsewd added this to the Cleanup milestone

Member

saadmk11 commented Mar 8, 2019

Okay. I'll remove the constant and double check if the tests are passing and submit a PR.

saadmk11 mentioned this issue

Removed unused constant from core.models #5424

Merged

stsewd closed this as completed in #5424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment