Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point users to use a configuration file from the import menu #5414

Closed
stsewd opened this issue Mar 7, 2019 · 4 comments
Closed

Point users to use a configuration file from the import menu #5414

stsewd opened this issue Mar 7, 2019 · 4 comments
Assignees
Labels
Design Design or UX/UI related Improvement Minor improvement to code Needed: design decision A core team decision is required

Comments

@stsewd
Copy link
Member

stsewd commented Mar 7, 2019

I was thinking we can put a link just next to the Edit advanced options or as a help text.

screenshot_2019-03-06 add a project read the docs 1

@stsewd stsewd added Design Design or UX/UI related Improvement Minor improvement to code Needed: design decision A core team decision is required labels Mar 7, 2019
@dhruvkb
Copy link

dhruvkb commented Mar 7, 2019

Correct me if I'm wrong in my understanding but this file is the point of discussion, is it not?
image

From a design point of view, I'd suggest a help text would be more efficient because a link to the advanced settings page would not exist before the project is added and clicking 'Next' to add the project would redirect the user to a different page anyway.

I'm new here and not very certain of the design aspect, but this seems like a good first issue. Can I work on this after we reach a design consensus?

@dojutsu-user
Copy link
Member

Hi @dhruvkb
@stsewd had already assigned this issue to himself and @davidfischer.
I would suggest you to please look into another issues.
Thanks

@stsewd
Copy link
Member Author

stsewd commented Mar 7, 2019

@dhruvkb thanks for the interest, but as mentioned, this work is already assigned. And for clarification, we are talking about this configuration file https://docs.readthedocs.io/en/stable/config-file/index.html

@davidfischer
Copy link
Contributor

Of the configurable options on the import screen's "advanced options", the only one that can be configured in the YAML file is the documentation type (sphinx, mkdocs, etc). That's also the only one that really must be configured before a project can be built. All the others are just metadata about the project.

Screen Shot 2019-03-12 at 4 40 41 PM

Proposal

  • I think we should completely remove the the "advanced project options" checkbox and form. This is totally unnecessary as all those things other than the documentation type can be tuned after the project is imported and built.
  • Instead, we should point people to the YAML config file documentation on the manual import page and we should even provide a sample config file with the most common options. Something like this:
version: 2
formats: all

# Build documentation in the docs/ directory with Sphinx
sphinx:
  configuration: docs/conf.py

python:
  version: 3.7
  
  # Python requirements required to build your docs
  install:
    - requirements: docs/requirements.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Design or UX/UI related Improvement Minor improvement to code Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

4 participants