Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"stable" not updating after deleting a tag #2858

Closed
aseering opened this issue May 21, 2017 · 9 comments
Closed

"stable" not updating after deleting a tag #2858

aseering opened this issue May 21, 2017 · 9 comments
Assignees
Labels
Bug A bug

Comments

@aseering
Copy link
Contributor

Details

What I did:

I deleted the tag "v1.68" from our repository. It was a typo (off-by-one); that version doesn't exist yet, we meant to add the previous version.

Expected Result

"v1.68" should be removed as a tag from our ReadTheDocs account. "stable" should be re-pointed at v1.67.

Actual Result

"v1.68" is still shown in ReadTheDocs, and (because it would be the newest version if it existed) "stable" points to it. I have tried marking "v1.68" as Inactive, but "stable" continues to build that revision.

I'm guessing y'all have a local checkout that's not correctly syncing the tag deletion. Is there a way we can force ReadTheDocs to blow away and re-check-out its copy of our repository?

@humitos
Copy link
Member

humitos commented Dec 27, 2017

Looking at the code, it should be removing the branches that doesn't exist anymore in the repository. If it's not enough, maybe, forcing to WIPE the environment should help.

The related code is at https://github.com/rtfd/readthedocs.org/blob/9bcb5fb2fe491ff68ac1466618344ce2347404e2/readthedocs/restapi/views/model_views.py#L163

and

https://github.com/rtfd/readthedocs.org/blob/9bcb5fb2fe491ff68ac1466618344ce2347404e2/readthedocs/restapi/utils.py#L56-L77

that code seems to do what you need.

Can you confirm that this is still a bug on RTD?

@humitos humitos added the Bug A bug label Dec 27, 2017
@aseering
Copy link
Contributor Author

I can confirm that the nonexistent-tag bug still exists.

stable no longer points to that tag because this bug is old enough that we have pushed a tag with a larger version number, which it now correctly points to.

You can see the docs here:
http://eureqa-api.nutonian.com/en/v1.68/

And you can see the repository tags on a dropdown on this page (or just check out the repository):
https://bitbucket.org/nutonian/eureqa_api/src

Note that the tag v1.68.0 does exist in both places. However, v1.68 does not exist in git; only in ReadTheDocs.

I've tried WIPEin the environment. Didn't help.

@humitos humitos self-assigned this Jan 28, 2018
@humitos
Copy link
Member

humitos commented Apr 4, 2018

It seems that we are not deleting Version anymore and this chunk of code is broken: #3887 (comment) has more information about this issue.

@andy-maier
Copy link

I also experience this issue on the python-zhmcclient project, and would like to register interest in its resolution.

@stsewd
Copy link
Member

stsewd commented Apr 27, 2018

@andy-maier there is a solution in progress ##3913

@Phlya
Copy link

Phlya commented Apr 29, 2018

I have a strange problem: among my tags in the project one contained a Cyrillic symbol which seemed to break the build. I removed that tag, and even re-created the project on readthedocs, but it is still listed in git show-ref --tags during the build, while if I do it from my computer it is not there anymore (or look at tags in the repo online).

@stsewd
Copy link
Member

stsewd commented Apr 29, 2018

@Phlya did you try wiping the environment? This can be done in the Versions section, edit button

@Phlya
Copy link

Phlya commented Apr 29, 2018

Yes, that helped - sorry, forgot to mention when I figured it out.

@humitos humitos assigned stsewd and unassigned humitos Jun 13, 2018
@stsewd
Copy link
Member

stsewd commented Aug 24, 2018

I see only two possible fixes here:

Also related to #4259

Closing in favor of the other issues, but I think this is already solved. Let us know if you still have this problem

@stsewd stsewd closed this as completed Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug
Projects
None yet
Development

No branches or pull requests

5 participants