Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GitHub merge queues when RTD PR builds are required to merge #10021

Open
gipert opened this issue Feb 14, 2023 · 1 comment
Open

Support GitHub merge queues when RTD PR builds are required to merge #10021

gipert opened this issue Feb 14, 2023 · 1 comment
Labels
Feature New feature Needed: design decision A core team decision is required

Comments

@gipert
Copy link

gipert commented Feb 14, 2023

Details

I tried to enable GitHub's merge queue on a project that enables reporting PR builds on GitHub and sets it as a required status check before merging.

Expected Result

The PR is automatically merged after all checks have passed.

Actual Result

GitHub waits for ReadTheDocs to report the PR status check, which is never reported. The PR stays in the queue and is never merged.

Related?

I had to add on: merge_group: [ref] to my GHA workflow file to fix a similar problem with the other required status checks run with GitHub Actions.

@humitos humitos added Feature New feature Needed: design decision A core team decision is required labels Feb 14, 2023
@webknjaz
Copy link
Contributor

@humitos I was just about to file a similar report. This is a blocker for projects wanting to use RTD with Merge Queues enabled.

I want to add that GitHub issues a push event in addition to merge_group, but RTD doesn't seem to react to it either.

This is what a deadlock this causes looks like:
Screenshot_2023-10-26-19-21-01-12_40deb401b9ffe8e1df2f1cc5ba480b12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

3 participants