Skip to content

Commit 4bc117c

Browse files
committed
Config: remove pipfile from schema
We don't support Pipfile and we decided we won't implement it for now (see #3181). I'm removing it from the schema and also its tests.
1 parent f057cbc commit 4bc117c

File tree

2 files changed

+1
-86
lines changed

2 files changed

+1
-86
lines changed

readthedocs/rtd_tests/fixtures/spec/v2/schema.yml

+1-17
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ python:
6464
system_packages: bool(required=False)
6565

6666
# Installation of packages and requiremens
67-
install: list(any(include('python-install-requirements'), include('python-install'), include('python-install-pipfile')), required=False)
67+
install: list(any(include('python-install-requirements'), include('python-install'), required=False)
6868

6969
python-install-requirements:
7070
# The path to the requirements file from the root of the project
@@ -83,22 +83,6 @@ python-install:
8383
# Default: []
8484
extra_requirements: list(str(), required=False)
8585

86-
python-install-pipfile:
87-
# The path to the directory that contains the Pipfile
88-
pipfile: path()
89-
90-
# Add the --dev option to pipenv install
91-
# Default: false
92-
dev: bool(required=False)
93-
94-
# Add the --ignore-pipfile option to pipenv install
95-
# Default: false
96-
ignore_pipfile: bool(required=False)
97-
98-
# Add the --skip-lock option to pipenv install
99-
# Default: true
100-
skip_lock: bool(required=False)
101-
10286
sphinx:
10387
# The builder type for the sphinx documentation
10488
# Default: 'html'

readthedocs/rtd_tests/tests/test_build_config.py

-69
Original file line numberDiff line numberDiff line change
@@ -329,75 +329,6 @@ def test_python_install_extra_requirements_empty(tmpdir, value):
329329
assertValidConfig(tmpdir, content.format(value=value))
330330

331331

332-
@pytest.mark.parametrize('pipfile', ['another_docs/', '.', 'project/'])
333-
def test_python_install_pipfile(tmpdir, pipfile):
334-
utils.apply_fs(
335-
tmpdir, {
336-
'another_docs': {
337-
'Pipfile': '',
338-
},
339-
'project': {},
340-
'Pipfile': '',
341-
},
342-
)
343-
content = '''
344-
version: "2"
345-
python:
346-
install:
347-
- pipfile: {}
348-
'''
349-
assertValidConfig(tmpdir, content.format(pipfile))
350-
351-
352-
@pytest.mark.parametrize('pipfile', ['docs/', '.', 'project/'])
353-
def test_python_install_pipfile_invalid(tmpdir, pipfile):
354-
utils.apply_fs(tmpdir, {})
355-
content = '''
356-
version: "2"
357-
python:
358-
install:
359-
- pipfile: {}
360-
'''
361-
content.format(pipfile)
362-
assertInvalidConfig(tmpdir, content, ['is not a path'])
363-
364-
365-
@pytest.mark.parametrize('value', ['true', 'false'])
366-
def test_python_install_pipfile_dev(tmpdir, value):
367-
content = '''
368-
version: "2"
369-
python:
370-
install:
371-
- pipfile: .
372-
dev: {value}
373-
'''
374-
assertValidConfig(tmpdir, content.format(value=value))
375-
376-
377-
@pytest.mark.parametrize('value', ['true', 'false'])
378-
def test_python_install_pipfile_skip_lock(tmpdir, value):
379-
content = '''
380-
version: "2"
381-
python:
382-
install:
383-
- pipfile: .
384-
skip_lock: {value}
385-
'''
386-
assertValidConfig(tmpdir, content.format(value=value))
387-
388-
389-
@pytest.mark.parametrize('value', ['true', 'false'])
390-
def test_python_install_pipfile_ignore_pipfile(tmpdir, value):
391-
content = '''
392-
version: "2"
393-
python:
394-
install:
395-
- pipfile: .
396-
ignore_pipfile: {value}
397-
'''
398-
assertValidConfig(tmpdir, content.format(value=value))
399-
400-
401332
@pytest.mark.parametrize('value', ['true', 'false'])
402333
def test_python_system_packages(tmpdir, value):
403334
content = '''

0 commit comments

Comments
 (0)