From 08b9a35f908647ce7d415b5c7a1df883f9aa267a Mon Sep 17 00:00:00 2001 From: Manuel Kaufmann Date: Thu, 2 May 2019 11:41:09 +0200 Subject: [PATCH] Remove USE_PDF_LATEXMK feature flag --- docs/guides/feature-flags.rst | 2 -- docs/guides/pdf-non-ascii-languages.rst | 7 ------- readthedocs/doc_builder/backends/sphinx.py | 3 --- readthedocs/doc_builder/templates/doc_builder/conf.py.tmpl | 2 -- readthedocs/projects/models.py | 2 -- 5 files changed, 16 deletions(-) diff --git a/docs/guides/feature-flags.rst b/docs/guides/feature-flags.rst index 4e257ab46b5..572cdffdee4 100644 --- a/docs/guides/feature-flags.rst +++ b/docs/guides/feature-flags.rst @@ -12,8 +12,6 @@ or disable one or more of these featured flags for a particular project. Available Flags --------------- -``USE_PDF_LATEXMK``: :featureflags:`USE_PDF_LATEXMK` - ``USE_SPHINX_LATEST``: :featureflags:`USE_SPHINX_LATEST` ``ALLOW_DEPRECATED_WEBHOOKS``: :featureflags:`ALLOW_DEPRECATED_WEBHOOKS` diff --git a/docs/guides/pdf-non-ascii-languages.rst b/docs/guides/pdf-non-ascii-languages.rst index 6ab46ea58f4..0c18b277a42 100644 --- a/docs/guides/pdf-non-ascii-languages.rst +++ b/docs/guides/pdf-non-ascii-languages.rst @@ -1,13 +1,6 @@ Build PDF format for non-ASCII languages ======================================== - -.. warning:: - - To be able to follow this guide and build PDF with this method, - you need to ask the Read the Docs core team to enable ``USE_PDF_LATEXMK`` :doc:`feature flag ` in your project. - Please, `open an issue`_ in our repository asking for this, and wait for one of the core team to enable it. - .. _open an issue: https://github.com/rtfd/readthedocs.org/issues/new Sphinx offers different `LaTeX engines`_ that support Unicode characters and non-ASCII languages, diff --git a/readthedocs/doc_builder/backends/sphinx.py b/readthedocs/doc_builder/backends/sphinx.py index 66de92ace40..d4e8bdd692a 100644 --- a/readthedocs/doc_builder/backends/sphinx.py +++ b/readthedocs/doc_builder/backends/sphinx.py @@ -149,9 +149,6 @@ def get_config_params(self): 'dont_overwrite_sphinx_context': self.project.has_feature( Feature.DONT_OVERWRITE_SPHINX_CONTEXT, ), - 'use_pdf_latexmk': self.project.has_feature( - Feature.USE_PDF_LATEXMK, - ), } finalize_sphinx_context_data.send( diff --git a/readthedocs/doc_builder/templates/doc_builder/conf.py.tmpl b/readthedocs/doc_builder/templates/doc_builder/conf.py.tmpl index b5dac3f8505..fca9d18d1f2 100644 --- a/readthedocs/doc_builder/templates/doc_builder/conf.py.tmpl +++ b/readthedocs/doc_builder/templates/doc_builder/conf.py.tmpl @@ -141,7 +141,6 @@ if 'extensions' in globals(): else: extensions = ["readthedocs_ext.readthedocs"] -{% if use_pdf_latexmk %} project_language = '{{ project.language }}' # User's Sphinx configurations @@ -173,4 +172,3 @@ if chinese: latex_elements = latex_elements_user or latex_elements_rtd elif japanese: latex_engine = latex_engine_user or 'platex' -{% endif %} diff --git a/readthedocs/projects/models.py b/readthedocs/projects/models.py index 02127823c84..3f9204f0a3a 100644 --- a/readthedocs/projects/models.py +++ b/readthedocs/projects/models.py @@ -1337,12 +1337,10 @@ def add_features(sender, **kwargs): DONT_SHALLOW_CLONE = 'dont_shallow_clone' USE_TESTING_BUILD_IMAGE = 'use_testing_build_image' SHARE_SPHINX_DOCTREE = 'share_sphinx_doctree' - USE_PDF_LATEXMK = 'use_pdf_latexmk' DEFAULT_TO_MKDOCS_0_17_3 = 'default_to_mkdocs_0_17_3' FEATURES = ( (USE_SPHINX_LATEST, _('Use latest version of Sphinx')), - (USE_PDF_LATEXMK, _('Use latexmk to build the PDF')), (ALLOW_DEPRECATED_WEBHOOKS, _('Allow deprecated webhook views')), (PIP_ALWAYS_UPGRADE, _('Always run pip install --upgrade')), (SKIP_SUBMODULES, _('Skip git submodule checkout')),