Skip to content

Commit d5d44b3

Browse files
authored
feat: loosening up the npm engine requirements to easily allow npm@8 (#291)
1 parent 1c872fd commit d5d44b3

File tree

3 files changed

+11
-88
lines changed

3 files changed

+11
-88
lines changed

.github/workflows/ci.yml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,21 @@ on: [push]
33
jobs:
44
build:
55
runs-on: ubuntu-latest
6+
strategy:
7+
matrix:
8+
node-version: [12.x, 14.x, 16.x]
69

710
steps:
811
- uses: actions/[email protected]
912

1013
- uses: actions/[email protected]
1114
with:
12-
node-version: 14.15.1
15+
node-version: ${{ matrix.node-version }}
16+
17+
# Node 16 still ships with npm@8 so for compatibility reasons we're upping this for everything else.
18+
- name: Install npm@8
19+
if: matrix.node-version != '16.x'
20+
run: npm install -g npm@8
1321

14-
- run: npm install -g npm@7
1522
- run: npm ci
1623
- run: npm test

package-lock.json

Lines changed: 1 addition & 84 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@
1010
"url": "[email protected]:readmeio/eslint-config.git"
1111
},
1212
"engines": {
13-
"node": "^12 || ^14",
14-
"npm": "^7"
13+
"node": "^12 || ^14 || ^16"
1514
},
1615
"scripts": {
1716
"prepare": "husky install",

0 commit comments

Comments
 (0)