Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epub onTap "freeze" on device rotation #360

Closed
LubomirGanchev opened this issue Jun 26, 2023 · 2 comments
Closed

Epub onTap "freeze" on device rotation #360

LubomirGanchev opened this issue Jun 26, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@LubomirGanchev
Copy link

Bug Report

What happened?

When device is rotated in landscape for example, the onTap functionality seems to stop working. It doesn't seems to fix itself after rotating the device back to the original orientation. As I said in slack it happens on certain devices/models. For example it never happened on my personal OnePlus Nord (android 12). I am attaching a video captured on emulator using the readium test app.

Expected behavior

How to reproduce?

Open the test app and load a book (in this example i used Le Mystere from the OPDS Test catalog). Once the book is loaded rotate the device orientation and tap in the middle or the sides.

video.mp4

Environment

  • Readium version: 2.3.0

Development environment

  • OS: Windows 11
  • IDE: Android Studio Chipmunk | 2021.2.1 Patch 2

Testing device

  • Android version:
  • Model: Xiaomi 11 Lite 5G NE | MIUI 14.0.6
  • Is it an emulator? No

  • Android version:
  • Model: Pixel 5 API 33
  • Is it an emulator? Yes

Additional context

@mickael-menu
Copy link
Member

@LubomirGanchev Let me know if this helps: #361

@mickael-menu mickael-menu added the bug Something isn't working label Jul 1, 2023
@LubomirGanchev
Copy link
Author

Hi Michael, sorry for the late answer, but this change seems to fix the problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants