Better Error Reporting for the New Architecture

[krystofwoldrich]

After adding support for React Native New Architecture to the @sentry/react-native error and performance monitoring library, we (@marandaneto, @kahest, @krystofwoldrich) noticed that Turbo Modules report errors differently than the original Native Modules. In some cases, parts of the stack trace were missing. We teamed up with @cortinico and @cipolleschi to investigate the changes and create this overview.

The goal of this post is to document the current state and compare this to expectations, and finally derive tasks and initiatives for improvement.

Summary

	Exception	Assert
JS	✅	NA
Native Module	✅	⚠️ (not pointing to cause)
Turbo Module	⚠️ (missing JS or CPP)	🚨⚠️ (missing JS)
CPP Module	⚠️ (missing CPP)	🚨⚠️ (missing JS)

Note
This summary applies both to Android and iOS

Legend

✅ All as expected (note something might be missing but it’s not subject to change)
⚠️ Missing part of the stack (JS or JAVA/ObjC or CPP)
🚨 Crashed App in Dev build
🚨⚠️ Crashed App in Dev build and missing part of the stack

Tests

Every entry has an expected field describing the ideal situation of what should the error reporting contain and actual describing what is currently reported. The expected is subject to change and the reason for this post is so we can align and discuss what should be reported and how.

Javascript

Besides console.error RedBox not pointing to the correct line everything works as expected.

This section consists of errors with a cause in Javascript code. Besides a minor issue with RedBox. This is more for completes of the overview.

✅ Error

Expected - stack trace points to the JS error
Actual - stack trace points to the JS error
(iOS doesn’t show RedBox, but the stack trace is correct)

throw new Error('Crash on JS')

Screenshots

⚠️ RedBox

Expected - stack trace points to console.error
Actual - stack trace point to the synthetic error

console.error('Red Box on JS')

Screenshots

✅ YellowBox

Expected - stack trace points to the console.warn
Actual - stack trace points to the console.warn

console.warn('Yellow Box on JS')

Screenshots

Turbo Modules

This section describes errors with a cause in Turbo Modules code, Kotlin, Java, or Objective-C.

Errors thrown in Turbo Modules behave differently based on the module function signature. We found that void functions throw Java/Obj-C errors and do not bubble to JS but functions with return values throw JS errors (without platform stack trace). Asserts work similarly.

Platform differences
Android and iOS work the same. The only difference is that Android shows the platform error (Java/Kotlin) on the screen in Dev builds and iOS doesn't (Obj-C).

⚠️ Error

Expected - stack trace points to the Java RuntimeException/NSException including the JS stack trace
Actual - stack trace points to the Java RuntimeException/NSException only or to the JavaScript Error only based on the method signature there are different outcomes.

For example void function throws an error in Java/Objective-C and no error bubbles up to Javascript, bool function bubbles the error to Javascript but without any additional information, no platform stack trace. We consider this the most important of all the findings.

Note for iOS: Xcode debugger stops the app during a crash and the developer has access to the stack, so showing the error on the screen doesn't make send in that case. Buf if someone is developing their app using react-native cli seeing the error on the screen the same way as in Android would be a large improvement to the dev experience.

override fun crashOnTurboModule() {
   throw RuntimeException("I crashed inside a TurboModule on the JVM layer")
}

- (void)crashOnTurboModule {
 // You can't add a `nil` to an array
 NSObject * nilObject = NULL;
 NSArray * _ = @[nilObject];
}

Here is a branch with a new test added to rn-tester showing different behavior based on the method signature.
facebook/react-native@main...krystofwoldrich:react-native:kw-turbo-modules-errors-tests

Screenshots

No iOS screenshots as the app crashes even in Dev build.

Stack traces

Kotlin stack trace

Exception in native call
java.lang.RuntimeException: I crashed inside a TurboModule on the JVM layer
	at com.rncrashplayground.modules.TurboCrashModule.crashOnTurboModule(TurboCrashModule.kt:10)
	at com.facebook.jni.NativeRunnable.run(Native Method)
	at android.os.Handler.handleCallback(Handler.java:942)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:27)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:228)
	at java.lang.Thread.run(Thread.java:1012)

Objective-C stack trace

'NSInvalidArgumentException', reason: '*** -[__NSPlaceholderArray initWithObjects:count:]: attempt to insert nil object from objects[0]'
*** First throw call stack:
(
	0   CoreFoundation                      0x00000001090c97c8 __exceptionPreprocess + 172
	1   libobjc.A.dylib                     0x0000000107571144 objc_exception_throw + 56
	2   CoreFoundation                      0x000000010914f108 -[__NSCFString characterAtIndex:].cold.1 + 0
	3   CoreFoundation                      0x000000010914c368 -[__NSPlaceholderArray initWithCapacity:].cold.1 + 0
	4   CoreFoundation                      0x0000000108fbc808 -[__NSPlaceholderArray initWithObjects:count:] + 184
	5   CoreFoundation                      0x00000001090b5988 +[NSArray arrayWithObjects:count:] + 36
	6   RNCrashPlayground                   0x0000000102387974 -[TurboCrashModule crashOnTurboModule] + 72
	7   CoreFoundation                      0x00000001090cfd00 __invoking___ + 144
	8   CoreFoundation                      0x00000001090ccee8 -[NSInvocation invoke] + 276
	9   CoreFoundation                      0x00000001090cd180 -[NSInvocation invokeWithTarget:] + 60
	10  RNCrashPlayground                   0x0000000102ff7e1c ___ZN8facebook5react15ObjCTurboModule23performMethodInvocationERNS_3jsi7RuntimeENS0_26TurboModuleMethodValueKindEPKcP12NSInvocationP14NSMutableArray_block_invoke + 228
	11  RNCrashPlayground                   0x000000010300a44c _ZZN8facebook5react15ObjCTurboModule23performMethodInvocationERNS_3jsi7RuntimeENS0_26TurboModuleMethodValueKindEPKcP12NSInvocationP14NSMutableArrayENK3$_1clEv + 32
	12  RNCrashPlayground                   0x000000010300a40c _ZNSt3__1L8__invokeIRZN8facebook5react15ObjCTurboModule23performMethodInvocationERNS1_3jsi7RuntimeENS2_26TurboModuleMethodValueKindEPKcP12NSInvocationP14NSMutableArrayE3$_1JEEEDTclscT_fp_spscT0_fp0_EEOSG_DpOSH_ + 24
	13  RNCrashPlayground                   0x000000010300a3c4 _ZNSt3__128__invoke_void_return_wrapperIvLb1EE6__callIJRZN8facebook5react15ObjCTurboModule23performMethodInvocationERNS3_3jsi7RuntimeENS4_26TurboModuleMethodValueKindEPKcP12NSInvocationP14NSMutableArrayE3$_1EEEvDpOT_ + 28
	14  RNCrashPlayground                   0x000000010300a39c _ZNSt3__110__function12__alloc_funcIZN8facebook5react15ObjCTurboModule23performMethodInvocationERNS2_3jsi7RuntimeENS3_26TurboModuleMethodValueKindEPKcP12NSInvocationP14NSMutableArrayE3$_1NS_9allocatorISF_EEFvvEEclEv + 28
	15  RNCrashPlayground                   0x0000000103008d2c _ZNSt3__110__function6__funcIZN8facebook5react15ObjCTurboModule23performMethodInvocationERNS2_3jsi7RuntimeENS3_26TurboModuleMethodValueKindEPKcP12NSInvocationP14NSMutableArrayE3$_1NS_9allocatorISF_EEFvvEEclEv + 28
	16  RNCrashPlayground                   0x000000010286d228 _ZNKSt3__110__function12__value_funcIFvvEEclEv + 60
	17  RNCrashPlayground                   0x000000010286d1e0 _ZNKSt3__18functionIFvvEEclEv + 24
	18  RNCrashPlayground                   0x0000000103016298 ___ZN12_GLOBAL__N_128MethodQueueNativeCallInvoker11invokeAsyncEONSt3__18functionIFvvEEE_block_invoke + 44
	19  libdispatch.dylib                   0x00000001088f0594 _dispatch_call_block_and_release + 24
	20  libdispatch.dylib                   0x00000001088f1d5c _dispatch_client_callout + 16
	21  libdispatch.dylib                   0x00000001088fa040 _dispatch_lane_serial_drain + 928
	22  libdispatch.dylib                   0x00000001088fad80 _dispatch_lane_invoke + 428
	23  libdispatch.dylib                   0x0000000108908b40 _dispatch_workloop_worker_thread + 1720
	24  libsystem_pthread.dylib             0x000000010c1478fc _pthread_wqthread + 284
	25  libsystem_pthread.dylib             0x000000010c1466c0 start_wqthread + 8
)

⚠️ Assert

Expected - stack trace points to the Java Assert/RCTAssert with JS stack trace (should not crash in Dev build)
Actual - stack trace points to the Java Assert/RCTAssert

override fun assertOnTurboModule() {
    assert(false) {
        "I failed an assert inside a TurboModule on the JVM layer"
    }
}

- (void)assertOnTurboModule {
 RCTAssert(false, @"Asserting on iOS");
}

Screenshots

No screenshots as the app crashes even in Dev build.

Stack traces

Kotlin stack trace

Exception in native call
java.lang.RuntimeException: I crashed inside a TurboModule on the JVM layer
	at com.rncrashplayground.modules.TurboCrashModule.crashOnTurboModule(TurboCrashModule.kt:10)
	at com.facebook.jni.NativeRunnable.run(Native Method)
	at android.os.Handler.handleCallback(Handler.java:942)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:27)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:228)
	at java.lang.Thread.run(Thread.java:1012)

Objective-C stack trace

'NSInternalInconsistencyException', reason: 'Asserting on iOS'
*** First throw call stack:
(
	0   CoreFoundation                      0x000000010bbe97c8 __exceptionPreprocess + 172
	1   libobjc.A.dylib                     0x000000010a4c9144 objc_exception_throw + 56
	2   Foundation                          0x000000010d34bccc -[NSMutableDictionary(NSMutableDictionary) classForCoder] + 0
	3   RNCrashPlayground                   0x0000000104e9f8c8 -[TurboCrashModule assertOnTurboModule] + 176
	4   CoreFoundation                      0x000000010bbefd00 __invoking___ + 144
	5   CoreFoundation                      0x000000010bbecee8 -[NSInvocation invoke] + 276
	6   CoreFoundation                      0x000000010bbed180 -[NSInvocation invokeWithTarget:] + 60
	7   RNCrashPlayground                   0x0000000105b0fe1c ___ZN8facebook5react15ObjCTurboModule23performMethodInvocationERNS_3jsi7RuntimeENS0_26TurboModuleMethodValueKindEPKcP12NSInvocationP14NSMutableArray_block_invoke + 228
	8   RNCrashPlayground                   0x0000000105b2244c _ZZN8facebook5react15ObjCTurboModule23performMethodInvocationERNS_3jsi7RuntimeENS0_26TurboModuleMethodValueKindEPKcP12NSInvocationP14NSMutableArrayENK3$_1clEv + 32
	9   RNCrashPlayground                   0x0000000105b2240c _ZNSt3__1L8__invokeIRZN8facebook5react15ObjCTurboModule23performMethodInvocationERNS1_3jsi7RuntimeENS2_26TurboModuleMethodValueKindEPKcP12NSInvocationP14NSMutableArrayE3$_1JEEEDTclscT_fp_spscT0_fp0_EEOSG_DpOSH_ + 24
	10  RNCrashPlayground                   0x0000000105b223c4 _ZNSt3__128__invoke_void_return_wrapperIvLb1EE6__callIJRZN8facebook5react15ObjCTurboModule23performMethodInvocationERNS3_3jsi7RuntimeENS4_26TurboModuleMethodValueKindEPKcP12NSInvocationP14NSMutableArrayE3$_1EEEvDpOT_ + 28
	11  RNCrashPlayground                   0x0000000105b2239c _ZNSt3__110__function12__alloc_funcIZN8facebook5react15ObjCTurboModule23performMethodInvocationERNS2_3jsi7RuntimeENS3_26TurboModuleMethodValueKindEPKcP12NSInvocationP14NSMutableArrayE3$_1NS_9allocatorISF_EEFvvEEclEv + 28
	12  RNCrashPlayground                   0x0000000105b20d2c _ZNSt3__110__function6__funcIZN8facebook5react15ObjCTurboModule23performMethodInvocationERNS2_3jsi7RuntimeENS3_26TurboModuleMethodValueKindEPKcP12NSInvocationP14NSMutableArrayE3$_1NS_9allocatorISF_EEFvvEEclEv + 28
	13  RNCrashPlayground                   0x0000000105385228 _ZNKSt3__110__function12__value_funcIFvvEEclEv + 60
	14  RNCrashPlayground                   0x00000001053851e0 _ZNKSt3__18functionIFvvEEclEv + 24
	15  RNCrashPlayground                   0x0000000105b2e298 ___ZN12_GLOBAL__N_128MethodQueueNativeCallInvoker11invokeAsyncEONSt3__18functionIFvvEEE_block_invoke + 44
	16  libdispatch.dylib                   0x000000010b410594 _dispatch_call_block_and_release + 24
	17  libdispatch.dylib                   0x000000010b411d5c _dispatch_client_callout + 16
	18  libdispatch.dylib                   0x000000010b41a040 _dispatch_lane_serial_drain + 928
	19  libdispatch.dylib                   0x000000010b41ad80 _dispatch_lane_invoke + 428
	20  libdispatch.dylib                   0x000000010b428b40 _dispatch_workloop_worker_thread + 1720
	21  libsystem_pthread.dylib             0x000000010eca38fc _pthread_wqthread + 284
	22  libsystem_pthread.dylib             0x000000010eca26c0 start_wqthread + 8
)

CPP Modules

Errors thrown in the CPP bubble to JS without the CPP stack trace. Asserts crash the app, CPP stack trace can be retrieved from crash reports.

Platform differences
Android and iOS work the same. Both show the JS stack trace in RedBox in Dev builds. And both crash without showing anything during a CPP error/assert.

⚠️ Error

Expected - CPP stack trace and JS stack trace
Actual - JS stack trace only

void TurboCxxCrashModule::crashOnCxxTurboModule(jsi::Runtime &rt)
{
 throw std::runtime_error("I crashed from inside a C++ TurboModule!");
}

Screenshots

Stack traces

Android stack trace

Error: Exception in HostFunction: I crashed from inside a C++ TurboModule!
	at crashOnCxxTurboModule (native)
	at crashOnCxxTurboModule (http://localhost:8081/App.bundle?platform=android&app=com.rncrashplayground&modulesOnly=true&dev=true&minify=false&runModule=true&shallow=true:82:119)
	at _performTransitionSideEffects (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.rncrashplayground&modulesOnly=false&runModule=true:49755:22)
	at _receiveSignal (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.rncrashplayground&modulesOnly=false&runModule=true:49711:45)
	at onResponderRelease (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.rncrashplayground&modulesOnly=false&runModule=true:49578:34)
	at apply (native)
	at invokeGuardedCallbackProd (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.rncrashplayground&modulesOnly=false&runModule=true:3164:21)
	at apply (native)
	at invokeGuardedCallback (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.rncrashplayground&modulesOnly=false&runModule=true:3250:42)
	at apply (native)
	at invokeGuardedCallbackAndCatchFirstError (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.rncrashplayground&modulesOnly=false&runModule=true:3253:36)
	at executeDispatch (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.rncrashplayground&modulesOnly=false&runModule=true:3317:48)
	at executeDispatchesInOrder (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.rncrashplayground&modulesOnly=false&runModule=true:3334:26)
	at executeDispatchesAndRelease (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.rncrashplayground&modulesOnly=false&runModule=true:5049:35)
	at executeDispatchesAndReleaseTopLevel (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.rncrashplayground&modulesOnly=false&runModule=true:5056:43)
	at forEach (native)
	at forEachAccumulated (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.rncrashplayground&modulesOnly=false&runModule=true:3776:22)
	at runEventsInBatch (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.rncrashplayground&modulesOnly=false&runModule=true:5067:27)
	at runExtractedPluginEventsInBatch (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.rncrashplayground&modulesOnly=false&runModule=true:5089:25)
	at anonymous (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.rncrashplayground&modulesOnly=false&runModule=true:5107:42)
	at batchedUpdates$1 (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.rncrashplayground&modulesOnly=false&runModule=true:14903:20)
	at batchedUpdates (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.rncrashplayground&modulesOnly=false&runModule=true:5038:36)
	at dispatchEvent (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&app=com.rncrashplayground&modulesOnly=false&runModule=true:5100:23)

iOS stack trace

Error: Exception in HostFunction: I crashed from inside a C++ TurboModule!
    at crashOnCxxTurboModule (native)
    at crashOnCxxTurboModule (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=org.reactjs.native.example.RNCrashPlayground:95448:117)
    at _performTransitionSideEffects (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=org.reactjs.native.example.RNCrashPlayground:49866:22)
    at _receiveSignal (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=org.reactjs.native.example.RNCrashPlayground:49822:45)
    at onResponderRelease (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=org.reactjs.native.example.RNCrashPlayground:49689:34)
    at apply (native)
    at invokeGuardedCallbackProd (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=org.reactjs.native.example.RNCrashPlayground:2910:21)
    at apply (native)
    at invokeGuardedCallback (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=org.reactjs.native.example.RNCrashPlayground:2996:42)
    at apply (native)
    at invokeGuardedCallbackAndCatchFirstError (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=org.reactjs.native.example.RNCrashPlayground:2999:36)
    at executeDispatch (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=org.reactjs.native.example.RNCrashPlayground:3063:48)
    at executeDispatchesInOrder (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=org.reactjs.native.example.RNCrashPlayground:3080:26)
    at executeDispatchesAndRelease (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=org.reactjs.native.example.RNCrashPlayground:4795:35)
    at executeDispatchesAndReleaseTopLevel (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=org.reactjs.native.example.RNCrashPlayground:4802:43)
    at forEach (native)
    at forEachAccumulated (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=org.reactjs.native.example.RNCrashPlayground:3522:22)
    at runEventsInBatch (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=org.reactjs.native.example.RNCrashPlayground:4813:27)
    at runExtractedPluginEventsInBatch (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=org.reactjs.native.example.RNCrashPlayground:4835:25)
    at anonymous (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=org.reactjs.native.example.RNCrashPlayground:4853:42)
    at batchedUpdates$1 (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=org.reactjs.native.example.RNCrashPlayground:14649:20)
    at batchedUpdates (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=org.reactjs.native.example.RNCrashPlayground:4784:36)
    at dispatchEvent (http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false&modulesOnly=false&runModule=true&app=org.reactjs.native.example.RNCrashPlayground:4846:23)

⚠️ Assert

Expected - CPP stack trace and JS stack trace (no crash in dev build)
Actual - CPP stack trace only

void TurboCxxCrashModule::rnAssertOnCxxTurboModule(jsi::Runtime &rt)
{
 react_native_assert(false && "I asserted from inside a C++ TurboModule!");
 // or
 assert(false);
}

Screenshots

No screenshots as the app crashes even in Dev build.

Stack traces

Android stack trace

Build fingerprint: 'google/sdk_gphone64_arm64/emu64a:13/TPB4.220624.004/8808248:userdebug/dev-keys'
Revision: '0'
ABI: 'arm64'
Timestamp: 2023-03-19 21:16:43.500387844+0100
Process uptime: 7s
Cmdline: com.rncrashplayground
pid: 25773, tid: 25889, name: mqt_js  >>> com.rncrashplayground <<<
uid: 10160
tagged_addr_ctrl: 0000000000000001 (PR_TAGGED_ADDR_ENABLE)
pac_enabled_keys: 000000000000000f (PR_PAC_APIAKEY, PR_PAC_APIBKEY, PR_PAC_APDAKEY, PR_PAC_APDBKEY)
signal 6 (SIGABRT), code -1 (SI_QUEUE), fault addr --------
Abort message: '/Users/krystofwoldrich/repos/RNCrashPlayground/android/app/src/main/jni/TurboCxxCrashModule.cpp:20: function rnAssertOnCxxTurboModule: assertion failed (false && "I asserted from inside a C++ TurboModule!")'
    x0  0000000000000000  x1  0000000000006521  x2  0000000000000006  x3  0000006e3265a250
    x4  00020d82000223da  x5  00020d82000223da  x6  00020d82000223da  x7  0001f17e00022406
    x8  00000000000000f0  x9  000000717ca81a00  x10 0000000000000001  x11 000000717cabfce4
    x12 000000717fc69030  x13 000000007fffffff  x14 0000000001002f7c  x15 000001d61d215197
    x16 000000717cb24d60  x17 000000717cb01b70  x18 0000006e2cc72000  x19 00000000000064ad
    x20 0000000000006521  x21 00000000ffffffff  x22 0000006ecfc15000  x23 0000006ecfc16000
    x24 0000006e3265af88  x25 0000000000000000  x26 b400006f4007be40  x27 0000000000000000
    x28 0000000000000000  x29 0000006e3265a2d0
    lr  000000717cab1868  sp  0000006e3265a230  pc  000000717cab1894  pst 0000000000001000
backtrace:
      #00 pc 0000000000051894  /apex/com.android.runtime/lib64/bionic/libc.so (abort+164) (BuildId: 058e3ec96fa600fb840a6a6956c6b64e)
      #01 pc 00000000006d28bc  /apex/com.android.art/lib64/libart.so (art::Runtime::Abort(char const*)+704) (BuildId: 97fdb979efb7d2b596fa4fceabaad95b)
      #02 pc 0000000000016ea8  /apex/com.android.art/lib64/libbase.so (android::base::SetAborter(std::__1::function<void (char const*)>&&)::$_3::__invoke(char const*)+80) (BuildId: b77c57f68a484ed93d5a7eda59d83bf9)
      #03 pc 0000000000009de0  /system/lib64/liblog.so (__android_log_assert+292) (BuildId: 1f951eeceedbbe038f287e24d36cbd34)
      #04 pc 0000000000000728  /data/app/~~NKq40mTGQQr3ShOV7Q9QKA==/com.rncrashplayground-yTAj76PUCc6BfgoS4ZzX_A==/lib/arm64/libreact_debug.so (react_native_assert_fail+104) (BuildId: c87ef983782b1668)
      #05 pc 0000000000029b78  /data/app/~~NKq40mTGQQr3ShOV7Q9QKA==/com.rncrashplayground-yTAj76PUCc6BfgoS4ZzX_A==/lib/arm64/libappmodules.so (facebook::react::TurboCxxCrashModule::rnAssertOnCxxTurboModule(facebook::jsi::Runtime&)+72) (BuildId: cdee61d01c3d962de73f61d0a8c069a0dc2bb57e)
<truncated to keep this document human redable> 

iOS stack trace from Crash Report

Thread 12 Crashed:: com.facebook.react.JavaScript
0   libsystem_kernel.dylib        	       0x110a8d0cc __pthread_kill + 8
1   libsystem_pthread.dylib       	       0x10ea171e8 pthread_kill + 256
2   libsystem_c.dylib             	       0x10b0d4e28 abort + 124
3   libsystem_c.dylib             	       0x10b0d4298 __assert_rtn + 268
4   RNCrashPlayground             	       0x104e7a3d8 facebook::react::TurboCxxCrashModule::rnAssertOnCxxTurboModule(facebook::jsi::Runtime&) + 156 (TurboCxxCrashModule.cpp:17)
5   RNCrashPlayground             	       0x104e7bb20 void facebook::react::bridging::callFromJs<void, facebook::react::TurboCxxCrashModule, void>(facebook::jsi::Runtime&, void (facebook::react::TurboCxxCrashModule::*)(facebook::jsi::Runtime&), std::__1::shared_ptr<facebook::react::CallInvoker> const&, facebook::react::TurboCxxCrashModule*) + 132 (Class.h:32)
6   RNCrashPlayground             	       0x104e7ad34 facebook::react::NativeTurboCxxCrashModuleCxxSpec<facebook::react::TurboCxxCrashModule>::Delegate::rnAssertOnCxxTurboModule(facebook::jsi::Runtime&) + 64 (AppSpecJSI.h:112)
7   RNCrashPlayground             	       0x1052cd048 facebook::react::__hostFunction_NativeTurboCxxCrashModuleCxxSpecJSI_rnAssertOnCxxTurboModule(facebook::jsi::Runtime&, facebook::react::TurboModule&, facebook::jsi::Value const*, unsigned long) + 56 (AppSpecJSI-generated.cpp:34)
8   RNCrashPlayground             	       0x105b26928 facebook::react::TurboModule::get(facebook::jsi::Runtime&, facebook::jsi::PropNameID const&, facebook::react::TurboModule::MethodMetadata const&)::$_0::operator()(facebook::jsi::Runtime&, facebook::jsi::Value const&, facebook::jsi::Value const*, unsigned long) const + 68 (TurboModule.cpp:30)
9   RNCrashPlayground             	       0x105b268c4 decltype(static_cast<facebook::react::TurboModule::get(facebook::jsi::Runtime&, facebook::jsi::PropNameID const&, facebook::react::TurboModule::MethodMetadata const&)::$_0&>(fp)(static_cast<facebook::jsi::Runtime&>(fp0), static_cast<facebook::jsi::Value const&>(fp0), static_cast<facebook::jsi::Value const*>(fp0), static_cast<unsigned long>(fp0))) std::__1::__invoke<facebook::react::TurboModule::get(facebook::jsi::Runtime&, facebook::jsi::PropNameID const&, facebook::react::TurboModule::MethodMetadata const&)::$_0&, facebook::jsi::Runtime&, facebook::jsi::Value const&, facebook::jsi::Value const*, unsigned long>(facebook::react::TurboModule::get(facebook::jsi::Runtime&, facebook::jsi::PropNameID const&, facebook::react::TurboModule::MethodMetadata const&)::$_0&, facebook::jsi::Runtime&, facebook::jsi::Value const&, facebook::jsi::Value const*&&, unsigned long&&) + 72 (type_traits:3918)
10  RNCrashPlayground             	       0x105b2684c facebook::jsi::Value std::__1::__invoke_void_return_wrapper<facebook::jsi::Value, false>::__call<facebook::react::TurboModule::get(facebook::jsi::Runtime&, facebook::jsi::PropNameID const&, facebook::react::TurboModule::MethodMetadata const&)::$_0&, facebook::jsi::Runtime&, facebook::jsi::Value const&, facebook::jsi::Value const*, unsigned long>(facebook::react::TurboModule::get(facebook::jsi::Runtime&, facebook::jsi::PropNameID const&, facebook::react::TurboModule::MethodMetadata const&)::$_0&, facebook::jsi::Runtime&, facebook::jsi::Value const&, facebook::jsi::Value const*&&, unsigned long&&) + 124 (invoke.h:30)
11  RNCrashPlayground             	       0x105b26774 std::__1::__function::__alloc_func<facebook::react::TurboModule::get(facebook::jsi::Runtime&, facebook::jsi::PropNameID const&, facebook::react::TurboModule::MethodMetadata const&)::$_0, std::__1::allocator<facebook::react::TurboModule::get(facebook::jsi::Runtime&, facebook::jsi::PropNameID const&, facebook::react::TurboModule::MethodMetadata const&)::$_0>, facebook::jsi::Value (facebook::jsi::Runtime&, facebook::jsi::Value const&, facebook::jsi::Value const*, unsigned long)>::operator()(facebook::jsi::Runtime&, facebook::jsi::Value const&, facebook::jsi::Value const*&&, unsigned long&&) + 124 (function.h:178)
12  RNCrashPlayground             	       0x105b254b4 std::__1::__function::__func<facebook::react::TurboModule::get(facebook::jsi::Runtime&, facebook::jsi::PropNameID const&, facebook::react::TurboModule::MethodMetadata const&)::$_0, std::__1::allocator<facebook::react::TurboModule::get(facebook::jsi::Runtime&, facebook::jsi::PropNameID const&, facebook::react::TurboModule::MethodMetadata const&)::$_0>, facebook::jsi::Value (facebook::jsi::Runtime&, facebook::jsi::Value const&, facebook::jsi::Value const*, unsigned long)>::operator()(facebook::jsi::Runtime&, facebook::jsi::Value const&, facebook::jsi::Value const*&&, unsigned long&&) + 124 (function.h:352)
13  RNCrashPlayground             	       0x105a1711c std::__1::__function::__value_func<facebook::jsi::Value (facebook::jsi::Runtime&, facebook::jsi::Value const&, facebook::jsi::Value const*, unsigned long)>::operator()(facebook::jsi::Runtime&, facebook::jsi::Value const&, facebook::jsi::Value const*&&, unsigned long&&) const + 156 (function.h:505)
14  RNCrashPlayground             	       0x105a1705c std::__1::function<facebook::jsi::Value (facebook::jsi::Runtime&, facebook::jsi::Value const&, facebook::jsi::Value const*, unsigned long)>::operator()(facebook::jsi::Runtime&, facebook::jsi::Value const&, facebook::jsi::Value const*, unsigned long) const + 144 (function.h:1182)
15  RNCrashPlayground             	       0x105a16fc0 facebook::jsi::DecoratedHostFunction::operator()(facebook::jsi::Runtime&, facebook::jsi::Value const&, facebook::jsi::Value const*, unsigned long) + 84 (decorator.h:36)
16  RNCrashPlayground             	       0x105a16f4c decltype(static_cast<facebook::jsi::DecoratedHostFunction&>(fp)(static_cast<facebook::jsi::Runtime&>(fp0), static_cast<facebook::jsi::Value const&>(fp0), static_cast<facebook::jsi::Value const*>(fp0), static_cast<unsigned long>(fp0))) std::__1::__invoke<facebook::jsi::DecoratedHostFunction&, facebook::jsi::Runtime&, facebook::jsi::Value const&, facebook::jsi::Value const*, unsigned long>(facebook::jsi::DecoratedHostFunction&, facebook::jsi::Runtime&, facebook::jsi::Value const&, facebook::jsi::Value const*&&, unsigned long&&) + 72 (type_traits:3918)
17  RNCrashPlayground             	       0x105a16ed4 facebook::jsi::Value std::__1::__invoke_void_return_wrapper<facebook::jsi::Value, false>::__call<facebook::jsi::DecoratedHostFunction&, facebook::jsi::Runtime&, facebook::jsi::Value const&, facebook::jsi::Value const*, unsigned long>(facebook::jsi::DecoratedHostFunction&, facebook::jsi::Runtime&, facebook::jsi::Value const&, facebook::jsi::Value const*&&, unsigned long&&) + 124 (invoke.h:30)
18  RNCrashPlayground             	       0x105a16dfc std::__1::__function::__alloc_func<facebook::jsi::DecoratedHostFunction, std::__1::allocator<facebook::jsi::DecoratedHostFunction>, facebook::jsi::Value (facebook::jsi::Runtime&, facebook::jsi::Value const&, facebook::jsi::Value const*, unsigned long)>::operator()(facebook::jsi::Runtime&, facebook::jsi::Value const&, facebook::jsi::Value const*&&, unsigned long&&) + 124 (function.h:178)
19  RNCrashPlayground             	       0x105a157c4 std::__1::__function::__func<facebook::jsi::DecoratedHostFunction, std::__1::allocator<facebook::jsi::DecoratedHostFunction>, facebook::jsi::Value (facebook::jsi::Runtime&, facebook::jsi::Value const&, facebook::jsi::Value const*, unsigned long)>::operator()(facebook::jsi::Runtime&, facebook::jsi::Value const&, facebook::jsi::Value const*&&, unsigned long&&) + 124 (function.h:352)
<truncated to keep this human redable>

Native Modules (Legacy)

Due to the Bridge limitations (async and batching) bubbling the errors would not be possible. We don't expect any changes here.

✅ Java/Kotlin Error

Expected - stack trace points to the Java RuntimeException
Actual - stack trace points to the Java RuntimeException

@ReactMethod
public void crashOnTheJvm() {
 throw new RuntimeException("I just crashed on Java");
}

Screenshots

Stack traces

Kotlin stack trace

Exception in native call
java.lang.RuntimeException: I just crashed on Java
	at com.rncrashplayground.modules.JavaCrashModule.crashOnTheJvm(JavaCrashModule.java:23)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.facebook.react.bridge.JavaMethodWrapper.invoke(JavaMethodWrapper.java:372)
	at com.facebook.react.bridge.JavaModuleWrapper.invoke(JavaModuleWrapper.java:188)
	at com.facebook.jni.NativeRunnable.run(Native Method)
	at android.os.Handler.handleCallback(Handler.java:942)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:27)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:228)
	at java.lang.Thread.run(Thread.java:1012)

⚠️ Java/Kotlin Assert

Expected - stack trace points to the Java Assert
Actual - stack trace points to the Java RuntimeException

@ReactMethod
public void assertOnTheJvm() {
 assert false : "Assert failed";
}

Screenshots

Stack traces

Kotlin stack trace

Exception in native call
java.lang.RuntimeException: Could not invoke JavaCrashModule.assertOnTheJvm
	at com.facebook.react.bridge.JavaMethodWrapper.invoke(JavaMethodWrapper.java:383)
	at com.facebook.react.bridge.JavaModuleWrapper.invoke(JavaModuleWrapper.java:188)
	at com.facebook.jni.NativeRunnable.run(Native Method)
	at android.os.Handler.handleCallback(Handler.java:942)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:27)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:228)
	at java.lang.Thread.run(Thread.java:1012)
Caused by: java.lang.reflect.InvocationTargetException
	at java.lang.reflect.Method.invoke(Native Method)
	at com.facebook.react.bridge.JavaMethodWrapper.invoke(JavaMethodWrapper.java:372)
	at com.facebook.react.bridge.JavaModuleWrapper.invoke(JavaModuleWrapper.java:188) 
	at com.facebook.jni.NativeRunnable.run(Native Method) 
	at android.os.Handler.handleCallback(Handler.java:942) 
	at android.os.Handler.dispatchMessage(Handler.java:99) 
	at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:27) 
	at android.os.Looper.loopOnce(Looper.java:201) 
	at android.os.Looper.loop(Looper.java:288) 
	at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:228) 
	at java.lang.Thread.run(Thread.java:1012) 
Caused by: java.lang.AssertionError: Assert failed
	at com.rncrashplayground.modules.JavaCrashModule.assertOnTheJvm(JavaCrashModule.java:28)
	at java.lang.reflect.Method.invoke(Native Method) 
	at com.facebook.react.bridge.JavaMethodWrapper.invoke(JavaMethodWrapper.java:372) 
	at com.facebook.react.bridge.JavaModuleWrapper.invoke(JavaModuleWrapper.java:188) 
	at com.facebook.jni.NativeRunnable.run(Native Method) 
	at android.os.Handler.handleCallback(Handler.java:942) 
	at android.os.Handler.dispatchMessage(Handler.java:99) 
	at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:27) 
	at android.os.Looper.loopOnce(Looper.java:201) 
	at android.os.Looper.loop(Looper.java:288) 
	at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:228) 

[cipolleschi]

Thanks, this is awesome!
When you find the time to work on the iOS part, it would be great to highlight any differences, if any, between iOS and Android.
If you already did this check and there are no differences, perhaps is worth call out that the two platforms behaves in the same way, which is a good thing.

What do you think?

[krystofwoldrich]

I agree. They behave the same with small differences in showing the RedBox in Dev builds.
I'll update the post, so it's more clear.