Add spinner component #1347 #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mjdavidson
commented
Jan 7, 2019
•
mjdavidson
commented
- Bug fix
- New feature
- Chore
- Breaking change
- There is an open issue which this change addresses
- I have read the CONTRIBUTING document.
- My commits follow the Git Commit Guidelines
- My code follows the code style of this project.
- My change requires a change to the documentation.
-
- I have updated the documentation accordingly.
- I have added tests to cover my changes.
- All new and existing tests passed.
Allow role to be overridden map `sr-only` for cssModule.
juanmaguitar
added a commit
to juanmaguitar/reactstrap
that referenced
this pull request
Jan 18, 2019
* 'master' of github.com:reactstrap/reactstrap: (81 commits) fix(Modal): set Modal.openCount floor to 0 (reactstrap#1368) feat(Popover): add default toggleable fade support (reactstrap#1364) (reactstrap#1364) chore(release): release 7.1.0 feat(Popover): add legacy trigger, replacing isInteractive prop feat(Popover): backward-compatible Popover behavior (reactstrap#1360) Fix(Modal): don't treat clicks on Portal children as backdrop clicks (reactstrap#1359) feat(*): support forwardRef components as tag fix(NavLink): console error while using @reach/Router (reactstrap#1350) feat(Spinner): Add spinner component (reactstrap#1352) feat(Switch): Add support for CustomInput type='switch' (reactstrap#1353) chore(release): adding 7.0.2 fix(npm): fix published files chore(release): adding 7.0.1 fix(*): fix release artifacts (reactstrap#1345) chore(release): adding 7.0.0 (reactstrap#1342) docs(typo): Fix misspelling in documentation (Alerts) (reactstrap#1329) docs(Input): static input error (reactstrap#1335) fix lint issue Bug/v7 merge conflict fix (reactstrap#1324) feat(CardBody): add innerRef to CardBody (reactstrap#1318) ...
|
Any idea when the docs for this component will go live at https://reactstrap.github.io/? Also, looks like the types are missing for Spinner in the latest released version, 6.4.4. https://www.npmjs.com/package/@types/reactstrap Would it be reasonable to add updating the types to the checklist? |
twilco
added a commit
to twilco/DefinitelyTyped
that referenced
this pull request
Jan 19, 2019
The Spinner component was added to reactstrap here: reactstrap/reactstrap#1352
|
Oh, I just found this PR: DefinitelyTyped/DefinitelyTyped#32206 Still might be worth adding to the checklist, maybe suggesting a link to the PR in which the types are added? 🙂 |
|
The docs were published when the PR was merged (even before the component was in a release), they can be found at https://reactstrap.github.io/components/spinners/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.