Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] zoomlogin #1555

Closed
5 tasks done
day-lee opened this issue Oct 13, 2024 · 2 comments · Fixed by #1554
Closed
5 tasks done

[Refactor] zoomlogin #1555

day-lee opened this issue Oct 13, 2024 · 2 comments · Fixed by #1554
Assignees
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: refactor need to refactor codebase hacktoberfest 🏁 status: ready for dev Ready for work

Comments

@day-lee
Copy link
Contributor

day-lee commented Oct 13, 2024

File Name

‎src/plays/zoomlogin/components/chatbot/widget/InitialButtonOptions.jsx
src/plays/zoomlogin/components/Zoom/ZoomSupport.js
‎src/plays/zoomlogin/components/Zoom/ZoomSignin.js

Reason for Refactoring the Code

  • Chatbot option buttons have either hover:cursor-pointer or hover:cursor-not-allowed depending on the feature development. "My Account is Locked" is developed but stated as not allowed, hence changed the cursor accordingly.
  • removed unused file ZoomSupport.js
  • refactor label htmlFor to match the input id in ZoomSignin.js

Record

@day-lee day-lee added 💻 aspect: code Concerns the software code in the repository 🚦status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: refactor need to refactor codebase labels Oct 13, 2024
Copy link

Hey! contributor, thank you for opening an Issue 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

@PriteshKiri
Copy link
Contributor

Thanks for your contribution @day-lee 🙌

@priyankarpal priyankarpal added hacktoberfest 🏁 status: ready for dev Ready for work and removed 🚦status: awaiting triage Has not been triaged & therefore, not ready for work labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: refactor need to refactor codebase hacktoberfest 🏁 status: ready for dev Ready for work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants