Skip to content

Explicitly close streaming response body when body MUST be empty #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2021
Merged

Explicitly close streaming response body when body MUST be empty #429

merged 1 commit into from
Nov 6, 2021

Conversation

@clue
Copy link
Member

@clue clue commented Nov 4, 2021 •
edited
Loading

This changeset ensures we explicitly close any streaming response body when the response body MUST be empty, such as for HEAD requests, 204 No Content and 304 Not Modified.

Builds on top of #188 and #156

@clue clue added this to the v1.6.0 milestone Nov 4, 2021
@clue clue requested a review from WyriHaximus November 4, 2021 16:08
@clue clue mentioned this pull request Nov 4, 2021
Merged
This was referenced Nov 5, 2021
Merged
Merged
@WyriHaximus WyriHaximus merged commit 3e2caeb into reactphp:master Nov 6, 2021
@clue clue deleted the close-unused-body branch November 7, 2021 09:30
@clue clue mentioned this pull request Feb 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@SimonFrings SimonFrings SimonFrings approved these changes

Assignees

No one assigned

Labels

bug new feature

Projects

None yet

Milestone

v1.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@clue @WyriHaximus @SimonFrings