Skip to content

Commit 4daaadc

Browse files
committed
refactor hvigor-plugin to use 2-space indentation for JSON and improve condition checks in RCTPushy
1 parent 43ed2f5 commit 4daaadc

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

harmony/pushy/hvigor-plugin.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,9 @@ export function reactNativeUpdatePlugin() {
3030
versionName,
3131
};
3232

33-
fs.writeFileSync(metaFilePath, JSON.stringify(metaContent, null, 4));
33+
fs.writeFileSync(metaFilePath, JSON.stringify(metaContent, null, 2));
3434
console.log(`Build time written to ${metaFilePath}`);
3535
},
36-
dependencies: [],
37-
postDependencies: ['default@BuildJS'],
3836
});
3937
},
4038
};

ios/RCTPushy/RCTPushy.mm

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,15 +78,15 @@ + (NSURL *)bundleURL
7878
NSString *storedBuildTime = [defaults stringForKey:paramBuildTime];
7979

8080
// If stored versions don't exist, write current versions first
81-
if (!storedPackageVersion || !storedBuildTime) {
81+
if (!storedPackageVersion && !storedBuildTime) {
8282
[defaults setObject:curPackageVersion forKey:paramPackageVersion];
8383
[defaults setObject:curBuildTime forKey:paramBuildTime];
8484
storedPackageVersion = curPackageVersion;
8585
storedBuildTime = curBuildTime;
8686
}
8787

8888
BOOL packageVersionChanged = ![curPackageVersion isEqualToString:storedPackageVersion];
89-
BOOL buildTimeChanged = ![curBuildTime isEqualToString:storedBuildTime];
89+
BOOL buildTimeChanged = curBuildTime && ![curBuildTime isEqualToString:storedBuildTime];
9090

9191
if (packageVersionChanged || buildTimeChanged) {
9292
// Clear all update data and store new versions
@@ -304,8 +304,8 @@ - (instancetype)init
304304
if (hash.length) {
305305
NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
306306
NSString *lastVersion = nil;
307-
if ([defaults objectForKey:keyPushyInfo]) {
308-
NSDictionary *pushyInfo = [defaults objectForKey:keyPushyInfo];
307+
NSDictionary *pushyInfo = [defaults objectForKey:keyPushyInfo]
308+
if (pushyInfo) {
309309
lastVersion = pushyInfo[paramCurrentVersion];
310310
}
311311

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-native-update",
3-
"version": "10.35.4",
3+
"version": "10.35.5",
44
"description": "react-native hot update",
55
"main": "src/index",
66
"scripts": {

0 commit comments

Comments
 (0)