Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CSSTransition): done classname for appearing #383

Closed
wants to merge 1 commit into from
Closed

fix(CSSTransition): done classname for appearing #383

wants to merge 1 commit into from

Conversation

koba04
Copy link
Member

@koba04 koba04 commented Jul 24, 2018

Fix #327

@silvenon
Copy link
Collaborator

Thanks for this! There's a discussion in #327 about which classes to apply exactly, feel free to join in.

@silvenon silvenon closed this in fe3c156 Apr 6, 2019
jquense pushed a commit that referenced this pull request Apr 6, 2019
@semantic-release-bot
chore(release): 2.9.0 [skip ci]
2eb45b2 
# [2.9.0](v2.8.0...v2.9.0) (2019-04-06)

### Features

* **CSSTransition:** add "done" class for appear ([fe3c156](fe3c156)), closes [#383](#383) [#327](#327) [#327](#327)

### Reverts

* bump semantic release dependencies ([1bdcaec](1bdcaec))
@jquense
Copy link
Collaborator

jquense commented Apr 6, 2019

🎉 This issue has been resolved in version 2.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@koba04
Copy link
Member Author

koba04 commented Apr 8, 2019

Thanks!

@koba04 koba04 deleted the fix-appear-done-classname branch April 8, 2019 14:41
@silvenon
Copy link
Collaborator

silvenon commented Apr 9, 2019

@koba04 thanks for suggesting the change and the PR. 😉

This was referenced Sep 24, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Mar 13, 2020
Closed
This was referenced Mar 26, 2020
Merged
Open
@snyk-bot snyk-bot mentioned this pull request Apr 13, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request May 2, 2020
Closed
johnfrench3 pushed a commit to johnfrench3/transition-group-react that referenced this pull request Nov 2, 2022
chore(release): 2.9.0 [skip ci]
c673dd4 
# [2.9.0](reactjs/react-transition-group@v2.8.0...v2.9.0) (2019-04-06)

### Features

* **CSSTransition:** add "done" class for appear ([fe3c156](reactjs/react-transition-group@fe3c156)), closes [#383](reactjs/react-transition-group#383) [#327](reactjs/react-transition-group#327) [#327](reactjs/react-transition-group#327)

### Reverts

* bump semantic release dependencies ([1bdcaec](reactjs/react-transition-group@1bdcaec))
patrickm68 added a commit to patrickm68/react-transition-group-developer that referenced this pull request Dec 1, 2022
@patrickm68
chore(release): 2.9.0 [skip ci]
8fc8308 
# [2.9.0](reactjs/react-transition-group@v2.8.0...v2.9.0) (2019-04-06)

### Features

* **CSSTransition:** add "done" class for appear ([fe3c156](reactjs/react-transition-group@fe3c156)), closes [#383](reactjs/react-transition-group#383) [#327](reactjs/react-transition-group#327) [#327](reactjs/react-transition-group#327)

### Reverts

* bump semantic release dependencies ([1bdcaec](reactjs/react-transition-group@1bdcaec))
shaikdev2 pushed a commit to shaikdev2/transition-group-react that referenced this pull request Jun 9, 2023
@paxaxel223
chore(release): 2.9.0 [skip ci]
c771aac 
# [2.9.0](reactjs/react-transition-group@v2.8.0...v2.9.0) (2019-04-06)

### Features

* **CSSTransition:** add "done" class for appear ([fe3c156](reactjs/react-transition-group@fe3c156)), closes [#383](reactjs/react-transition-group#383) [#327](reactjs/react-transition-group#327) [#327](reactjs/react-transition-group#327)

### Reverts

* bump semantic release dependencies ([1bdcaec](reactjs/react-transition-group@1bdcaec))
GreenCat1996 added a commit to GreenCat1996/react-transition-group that referenced this pull request Aug 1, 2023
@GreenCat1996
chore(release): 2.9.0 [skip ci]
1e9340e 
# [2.9.0](reactjs/react-transition-group@v2.8.0...v2.9.0) (2019-04-06)

### Features

* **CSSTransition:** add "done" class for appear ([fe3c156](reactjs/react-transition-group@fe3c156)), closes [#383](reactjs/react-transition-group#383) [#327](reactjs/react-transition-group#327) [#327](reactjs/react-transition-group#327)

### Reverts

* bump semantic release dependencies ([1bdcaec](reactjs/react-transition-group@1bdcaec))
This was referenced Sep 7, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koba04 @silvenon @jquense