Skip to content

Accessibility: Add focus to tab on click #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danez merged 1 commit into from
Mar 1, 2022
Merged

Accessibility: Add focus to tab on click #349

danez merged 1 commit into from
Mar 1, 2022

Conversation

@bozdoz
Copy link
Contributor

@bozdoz bozdoz commented Nov 25, 2020

  • fixes overwrite of state.focus

closes #272

danez
danez requested changes Dec 13, 2020
View reviewed changes
@danez
Copy link
Collaborator

danez commented Dec 13, 2020

Thanks for your contribution 💚

@danez danez added the major label Dec 13, 2020
Base automatically changed from master to main February 11, 2021 14:45
@danez danez changed the base branch from main to next March 1, 2022 14:03
@danez danez added this to the 4.0. milestone Mar 1, 2022
@bozdoz @danez
feat: Always set focus on tabs
636e469 
BREAKING CHANGE: The tabs are now instantly focused on click. The default styling has been adapted for that, so that there is no outline shown anymore on focus.

closes #272
danez
danez approved these changes Mar 1, 2022
View reviewed changes
Copy link
Collaborator

@danez danez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the contribution, I updated this so there are no conflicts with the main branch. The focus is now also always set. This will be released in the next major version.

@danez danez merged commit 252cd8f into reactjs:next Mar 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@danez danez danez approved these changes

+1 more reviewer

@MJolin MJolin MJolin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

major

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

Tab is Not Focussed on First Click

3 participants

@bozdoz @danez @MJolin