Skip to content

Should remove the xmlns:xlink entirely, and replace xlink:href to xlinkHref #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reggi opened this issue Apr 20, 2016 · 4 comments
Open

Comments

@reggi
Copy link

reggi commented Apr 20, 2016

I just used the html to jsx converter.

In the example of

<use xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="#next-remove" />

It should remove the xmlns:xlink entirely, and replace xlink:href to xlinkHref.

Thoughts

@Daniel15
Copy link
Member

Is that actually HTML? <use> isn't a HTML tag.

@reggi
Copy link
Author

reggi commented Apr 24, 2016

It's used within <svg>. Unsure how it should be treated. Support for xlinkHref exists in jsx.

@rayshan
Copy link

rayshan commented May 12, 2017

@osdiab
Copy link

osdiab commented Jun 2, 2017

xmlnsXlink is now supported in the React docs, so it probably shouldn't be eliminated. https://facebook.github.io/react/docs/dom-elements.html

Probably a better option is just to handle namespaced attributes by camelCasing them and eliminating the colon, since that's invalid JSX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants