Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onclick attribute not getting renamed to onClick #139

Open
jeffvandyke opened this issue Aug 17, 2017 · 1 comment
Open

onclick attribute not getting renamed to onClick #139

jeffvandyke opened this issue Aug 17, 2017 · 1 comment

Comments

@jeffvandyke
Copy link

jeffvandyke commented Aug 17, 2017

On http://magic.reactjs.net/htmltojsx.htm, I was able to almost perfectly convent a huge chunk of text, but I thought I should let someone know that the onclick attribute is not converting to onClick. Perhaps onclick="alert('hi'); return false;" could be converted to onClick={() => { alert('hi'); return false; }}, just as a suggestion. Thanks for this tool!

@Daniel15
Copy link
Member

Feel free to submit a pull request adding this, if you think it'll be useful :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants