Support printing created identifiers

Author: danez

flow-typed/recast.js

@@ -34,7 +34,4 @@ declare class NodePath {
   map<T>(f: (p: NodePath) => T): Array<T>;
   filter(f: (p: NodePath) => boolean): Array<NodePath>;
   push(node: ASTNode): void;
-
-  // our addition
-  getSrc(): string;
 }

src/utils/__tests__/__snapshots__/getPropType-test.js.snap

@@ -10,7 +10,7 @@ Object {
 exports[`getPropType detects custom validation functions for function 1`] = `
 Object {
   "name": "custom",
-  "raw": "(function() {})",
+  "raw": "function() {}",
 }
 `;
 

src/utils/__tests__/resolveObjectValuesToArray-test.js

@@ -66,6 +66,14 @@ describe('resolveObjectValuesToArray', () => {
     );
   });
 
+  it('does not resolve Object.values with complex computed key', () => {
+    const path = parse(
+      ['var foo = { [()=>{}]: 1, [5]: 2};', 'Object.values(foo);'].join('\n'),
+    );
+
+    expect(resolveObjectValuesToArray(path)).toBeNull();
+  });
+
   it('resolves Object.values when using resolvable spread', () => {
     const path = parse(
       [

src/utils/printValue.js

@@ -34,9 +34,17 @@ function getSrcFromAst(path: NodePath): string {
  * Prints the given path without leading or trailing comments.
  */
 export default function printValue(path: NodePath): string {
+  if (path.node.start == null) {
+    if (path.node.type === 'Literal') {
+      return `"${path.node.value}"`;
+    }
+    throw new Error(
+      `Cannot print raw value for type '${
+        path.node.type
+      }'. Please report this with an example at https://github.com/reactjs/react-docgen/issues`,
+    );
+  }
   const src = getSrcFromAst(path);
 
-  // TODO: Filter out comments in returned code
-
   return deindent(src.slice(path.node.start, path.node.end));
 }

src/utils/resolveObjectValuesToArray.js

@@ -111,7 +111,7 @@ export function resolveObjectToPropMap(
 }
 
 /**
- * Returns an ArrayExpression which contains all the keys resolved from an object
+ * Returns an ArrayExpression which contains all the values resolved from an object
  *
  * Ignores setters in objects
  *