Skip to content
This repository has been archived by the owner on Jul 19, 2019. It is now read-only.

Should dist and build folders store in repo? #120

Closed
blackrabbit99 opened this issue Jun 16, 2016 · 7 comments
Closed

Should dist and build folders store in repo? #120

blackrabbit99 opened this issue Jun 16, 2016 · 7 comments
Labels
Milestone

Comments

@blackrabbit99
Copy link

Is it really needed to store it in repo, maybe setup build process on prepublish hook and store dist into gh-pages repo? If you agree I can send PR for it.

@whichsteveyp
Copy link
Contributor

This was discussed in #109 as well, and a PR would be useful if you'd like to open one up!

@CMTegner CMTegner added this to the Release 1.1.0 milestone Jul 18, 2016
@CMTegner
Copy link
Collaborator

@blackrabbit99 gogogo! Let's see if we can get this sorted before 1.1 :)

@CMTegner CMTegner added the build label Jul 18, 2016
@blackrabbit99
Copy link
Author

@CMTegner I'm thinking about build on postinstall hook is it ok for you?

@CMTegner
Copy link
Collaborator

@blackrabbit99 don't think that would work since devDependencies are not included by default. Did you mean prepublish?

@blackrabbit99
Copy link
Author

@CMTegner yeap, I think prepublish would be enough for simple build using browserify.

@Daniel15
Copy link
Member

Yeah I don't think it makes sense to store dist in source control. It's totally fine (and in fact, highly encouraged) to offer a precompiled version, but that should be done through a proper release strategy such as npm or GitHub releases (or both, which is what I do for babel-standalone). Build artifacts don't belong in source control.

@CMTegner
Copy link
Collaborator

The transpiled source and UMD bundles have been removed from the repo and are only available from the npm package.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants