compare target/source in add_web_module()

also adds remove_web_module()

Author: rmorshea

src/idom/client/manage.py

@@ -60,14 +60,20 @@ def add_web_module(
     source: Union[Path, str],
 ) -> None:
     """Add a web module from source"""
-    if web_module_exists(package_name):
-        raise ValueError(f"Web module {package_name!r} already exists")
-    source = Path(source)
-    if not source.exists():
+    resolved_source = Path(source).resolve()
+    if not resolved_source.exists():
         raise FileNotFoundError(f"Package source file does not exist: {str(source)!r}")
     target = web_module_path(package_name)
+    if target.resolve() == resolved_source:
+        return None  # already added
     target.parent.mkdir(parents=True, exist_ok=True)
-    target.symlink_to(source.absolute())
+    # this will raise an error if already exists
+    target.symlink_to(resolved_source)
+
+
+def remove_web_module(package_name: str, must_exist: bool = False) -> None:
+    """Remove a web module"""
+    web_module_path(package_name, must_exist).unlink()
 
 
 def restore() -> None:

tests/test_client/test_manage.py

@@ -4,6 +4,7 @@
 from idom.client.manage import (
     add_web_module,
     build,
+    remove_web_module,
     restore,
     web_module_exists,
     web_module_exports,
@@ -31,11 +32,25 @@ def test_add_web_module_source_must_exist(tmp_path):
 
 
 def test_cannot_add_web_module_if_already_exists(tmp_path):
+    first_temp_file = tmp_path / "temp-1.js"
+    second_temp_file = tmp_path / "temp-2.js"
+
+    first_temp_file.write_text("console.log('hello!')")  # this won't get run
+    second_temp_file.write_text("console.log('hello!')")  # this won't get run
+
+    add_web_module("test", first_temp_file)
+    with pytest.raises(FileExistsError):
+        add_web_module("test", second_temp_file)
+
+    remove_web_module("test")
+
+
+def test_can_add_web_module_if_already_exists_and_source_is_same(tmp_path):
     temp_file = tmp_path / "temp.js"
-    temp_file.write_text("console.log('hello!')")  # this won't get run
+    temp_file.write_text("console.log('hello!')")
+    add_web_module("test", temp_file)
     add_web_module("test", temp_file)
-    with pytest.raises(ValueError, match="already exists"):
-        add_web_module("test", temp_file)
+    remove_web_module("test")
 
 
 def test_web_module_path_must_exist():