Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: package type module #1108

Merged
merged 1 commit into from
Nov 16, 2022
Merged

feat: package type module #1108

merged 1 commit into from
Nov 16, 2022

Conversation

dangreen
Copy link
Collaborator

now package is ESM only

BREAKING CHANGE: no commonjs support

@github-actions
Copy link

github-actions bot commented Nov 16, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/index.cjs 0 B (-100% 🔽) 0 ms (-100% 🔽) 0 ms (-100% 🔽) 0 ms
dist/index.js 629 B (-18.63% 🔽) 13 ms (-18.63% 🔽) 64 ms (-18.02% 🔽) 76 ms

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2022

Codecov Report

Merging #1108 (72a584d) into master (7f3ec96) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1108   +/-   ##
=======================================
  Coverage   89.93%   89.93%           
=======================================
  Files           4        4           
  Lines         328      328           
  Branches       31       31           
=======================================
  Hits          295      295           
  Misses         33       33           
Impacted Files Coverage Δ
src/chart.tsx 100.00% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)
src/typedCharts.tsx 100.00% <100.00%> (ø)
src/utils.ts 78.14% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

now package is ESM only

BREAKING CHANGE: no commonjs support
@wongmrdev
Copy link

How do we configure create react app with react-chart-js-2 to work with react-scripts test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants