Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: documentation examples: too much padding #1076

Closed
1 task
judfs opened this issue Oct 21, 2022 · 0 comments
Closed
1 task

[Bug]: documentation examples: too much padding #1076

judfs opened this issue Oct 21, 2022 · 0 comments
Labels

Comments

@judfs
Copy link

judfs commented Oct 21, 2022

Would you like to work on a fix?

  • Check this if you would like to implement a PR, we are more than happy to help you go through the process.

Current and expected behavior

Despite having plenty of screen real estate, I cannot sufficiently view your side-by-side code examples. In order to appreciate your samples, I've needed to open dev tools and hack at the style.

The original sample page with firefox maximized.
Screenshot 2022-10-21 at 16-18-40 Gradient Chart react-chartjs-2

Notably there is horizontal text overflow in the code sample even though it has a humble 80 char line length.

After turning off this style, the page is much more reasonable

--ifm-container-width-xl: 1320px;

Screenshot 2022-10-21 at 16-26-47 Gradient Chart react-chartjs-2

But with just that style changed, the page breaks at non maximized window size. The chart is fully gone. But unhelpful padding persists on the right.
Screenshot 2022-10-21 at 16-49-20 Gradient Chart react-chartjs-2

Also turning off this rule leaves something reasonable:

.docItemCol_pwNb {
	/* max-width: 75% !important; */
}

Screenshot 2022-10-21 at 16-55-18 Gradient Chart react-chartjs-2

Using more vertical space might be nice too, but at least 20 lines is workable.

My display is 3840x2160 at 100% scaling (Gnome desktop). Looking at it on a 1080p display on windows is also disappointing.

Please update your styles to better use space.

Reproduction

https://react-chartjs-2.js.org/examples/gradient-chart/

chart.js version

unknown

react-chartjs-2 version

master

Possible solution

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants