Skip to content

Commit 8adf78f

Browse files
guilhermebruzziFacebook Github Bot 8
authored andcommitted
FIX #9617 - Correct find local IP address when running on iOS device
Summary: React native's reload javascript option doesn't always work on iOS devices since version 0.29, as described in #9617 It only doesn't work when you have a mac on a wireless connection, because react-native-xcode.sh can't find your IP address correctly in this case and will just fallback to use the pre-bundling option on your app. This small change in react-native-xcode.sh fixed this issue for our project and should fix this issue for all mac users that use wireless connection and that will run a debug version of the app on a real iOS device. Closes #9964 Differential Revision: D3923035 fbshipit-source-id: 436cfa2103e10221270034233552ce34720505d3
1 parent 2289909 commit 8adf78f

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

packager/react-native-xcode.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,9 @@ if [[ "$CONFIGURATION" = "Debug" && "$PLATFORM_NAME" != "iphonesimulator" ]]; th
7575
PLISTBUDDY='/usr/libexec/PlistBuddy'
7676
PLIST=$TARGET_BUILD_DIR/$INFOPLIST_PATH
7777
IP=$(ipconfig getifaddr en0)
78+
if [ -z "$IP" ]; then
79+
IP=$(ifconfig | grep 'inet ' | grep -v 127.0.0.1 | cut -d\ -f2 | awk 'NR==1{print $1}')
80+
fi
7881
$PLISTBUDDY -c "Add NSAppTransportSecurity:NSExceptionDomains:localhost:NSTemporaryExceptionAllowsInsecureHTTPLoads bool true" "$PLIST"
7982
$PLISTBUDDY -c "Add NSAppTransportSecurity:NSExceptionDomains:$IP.xip.io:NSTemporaryExceptionAllowsInsecureHTTPLoads bool true" "$PLIST"
8083
echo "$IP.xip.io" > "$DEST/ip.txt"

0 commit comments

Comments
 (0)