feat: add an onReady callback to the container #8491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Expo app for the example from this branch is ready! expo.io/@react-navigation/react-navigation-example?release-channel=pr-8491 |
osdnk
reviewed
Jun 22, 2020
osdnk
approved these changes
Jun 22, 2020
Bardiamist
reviewed
Jun 25, 2020
|
|
||
| React.useEffect(() => { | ||
| onReadyRef.current = onReady; | ||
| }); |
There was a problem hiding this comment.
Without useEffect should be more stable:
const onReadyRef = React.useRef(onReady);
onReadyRef.current = onReady;
There was a problem hiding this comment.
That's not concurrent mode safe. Ref shouldn't be assigned during render.
JDMathew
reviewed
Dec 23, 2020
|
|
||
| React.useImperativeHandle(ref, () => refContainer.current); | ||
|
|
||
| const linkingContext = React.useMemo(() => ({ options: linking }), [linking]); | ||
|
|
||
| if (rest.initialState == null && isLinkingEnabled && !isReady) { | ||
| const isReady = rest.initialState != null || !isLinkingEnabled || isResolved; |
There was a problem hiding this comment.
Why did this change to || from && ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.