This repository has been archived by the owner on Feb 8, 2020. It is now read-only.
fix: interaction manager in stack #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satya164
reviewed
Jan 3, 2020
| @@ -159,12 +159,15 @@ export default class Card extends React.Component<Props> { | |||
| spec.animation === 'spring' ? Animated.spring : Animated.timing; | |||
|
|
|||
| onTransitionStart?.({ closing: Boolean(closing) }); | |||
| this.handleStartInteraction(); | |||
There was a problem hiding this comment.
small thing: can we set it before onTransitionStart? so user can still rely on it in transitionStart event
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
=======================================
Coverage 93.73% 93.73%
=======================================
Files 37 37
Lines 830 830
Branches 203 208 +5
=======================================
Hits 778 778
Misses 43 43
Partials 9 9Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.