Skip to content
This repository has been archived by the owner on May 26, 2019. It is now read-only.

CallKit uppercasing call uuid #23

Open
bsiddiqui opened this issue Dec 19, 2017 · 2 comments
Open

CallKit uppercasing call uuid #23

bsiddiqui opened this issue Dec 19, 2017 · 2 comments

Comments

@bsiddiqui
Copy link

bsiddiqui commented Dec 19, 2017

If I call RNCallKit.endCall('ae708c43-f567-4bcf-8940-fb7013a8aa30'), the end call callback will get data with the uuid uppercased:

{ callUUID: 'AE708C43-F567-4BCF-8940-FB7013A8AA30' }

Is that expected?

@brunsy
Copy link

brunsy commented Dec 20, 2017

It's caused by the use of NSUUID everywhere...
For now I ended up converting back to lowercase in the event listeners.

@ianlin would you accept a PR to accept mixed case but always return lowercase UUID's?

@ianlin
Copy link
Member

ianlin commented Dec 20, 2017

Hi @bsiddiqui @brunsy, thanks for pointing this out. Yeah definitely welcome any PR :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants