Skip to content

Conversation

@nandorojo
Copy link
Contributor

Importing with a * may have some issues with Web's tree shaking. This minor PR edits the import to import unstable_createElement directly to avoid any potential tree shaking issues.

Importing with a `*` may have some issues with Web's tree shaking. This minor PR edits the import to import `unstable_createElement` directly to avoid any potential tree shaking issues.
@nandorojo nandorojo requested a review from Naturalclar as a code owner March 14, 2022 21:58
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Naturalclar Naturalclar changed the title Optimize for web tree shaking chore: Optimize for web tree shaking Mar 15, 2022
@Naturalclar Naturalclar merged commit e996f62 into react-native-picker:master Mar 15, 2022
@Naturalclar
Copy link
Contributor

🎉 This PR is included in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants