Skip to content

Conversation

@alanjhughes
Copy link
Contributor

The check of getReactContext().hasCatalystInstance() inside onMeasure will return true on both architectures so it needs to be changed. Replaced it with BuildConfig.IS_NEW_ARCHITECTURE_ENABLED. Also updated the example to use the latest stable RN.

@alanjhughes alanjhughes requested a review from Naturalclar as a code owner May 20, 2024 19:51
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Naturalclar Naturalclar changed the title Change method of detecting the new arch fix: Change method of detecting the new arch May 21, 2024
@Naturalclar Naturalclar merged commit ec354fb into react-native-picker:master May 21, 2024
github-actions bot pushed a commit that referenced this pull request May 21, 2024
## [2.7.6](v2.7.5...v2.7.6) (2024-05-21)

### Bug Fixes

* Change method of detecting the new arch ([#569](#569)) ([ec354fb](ec354fb))
@Naturalclar
Copy link
Contributor

🎉 This PR is included in version 2.7.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants