Skip to content

fix: Use textColor instead of blackColor in RNCPicker MacOS #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2022
Merged

fix: Use textColor instead of blackColor in RNCPicker MacOS #413

merged 1 commit into from
Jun 23, 2022

Conversation

@k1mmm
Copy link
Contributor

@k1mmm k1mmm commented May 17, 2022

By using textColor instead of blackColor the color will adjust based on the system appearance (supporting dark/light mode)

@k1mmm
Use textColor instead of blackColor in RNCPicker MacOS
f7c6f1e 
By using textColor instead of blackColor the color will adjust based on the system appearance (supporting dark/light mode)
@k1mmm k1mmm requested a review from Naturalclar as a code owner May 17, 2022 13:04
Naturalclar
Naturalclar approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@k1mmm
Copy link
Contributor Author

k1mmm commented Jun 7, 2022

@Naturalclar Awesome! Seems to be a build problem that is not related to the commit regarding 'RCTTurboModuleManager'

@Naturalclar Naturalclar changed the title Use textColor instead of blackColor in RNCPicker MacOS fix: Use textColor instead of blackColor in RNCPicker MacOS Jun 23, 2022
@Naturalclar Naturalclar merged commit b198ccb into react-native-picker:master Jun 23, 2022
github-actions bot pushed a commit that referenced this pull request Jun 23, 2022
@semantic-release-bot
chore(release): 2.4.2 [skip ci]
99fd869 
## [2.4.2](v2.4.1...v2.4.2) (2022-06-23)

### Bug Fixes

* Remove jCenter as it is due to sunset ([#417](#417)) ([a731ea0](a731ea0))
* Use textColor instead of blackColor in RNCPicker MacOS ([#413](#413)) ([b198ccb](b198ccb))
@Naturalclar
Copy link
Contributor

Naturalclar commented Jun 23, 2022

🎉 This PR is included in version 2.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Naturalclar Naturalclar Naturalclar approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@k1mmm @Naturalclar