Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Build issue with removeSessionCookies function #146

Open
bennydu91 opened this issue Apr 19, 2022 · 5 comments
Open

Android Build issue with removeSessionCookies function #146

bennydu91 opened this issue Apr 19, 2022 · 5 comments

Comments

@bennydu91
Copy link

bennydu91 commented Apr 19, 2022

Hello !
I have update from last version (6.2.0) and I have an issue with removeSessionCookies function as you can see on this screenshot I didn't find any ticket about it, maybe you have a quick fix for this ?

Thank you !

@kjurkovicafinitos
Copy link

kjurkovicafinitos commented Apr 25, 2022

I have the same issue!
EDIT: @bennydu91 you can quickly fix this by setting line 106 in CookieManagerModule.java like this:
public void removeSessionCookies(Promise promise) .. -> public void removeSessionCookies(final Promise promise) ..

@mmathewsTableau
Copy link

Running into it as well. Workaround is great but would definitely appreciate a permanent fix so a local patch is not necessary.

@bennydu91
Copy link
Author

@kjurkovicafinitos Yep I've tried it but still not working unfortunately

@kjurkovicafinitos
Copy link

@bennydu91 what error are you seeing? Problem with workaround is that after every npm install, final will be removed and you need to add it again. Might that be the issue?

@bennydu91
Copy link
Author

After add final, without doing npm install, I try to build, gradle doesn't pop any error but after Metro generate bundle I have a blank screen on my emulator (Update package is my only change on this branch and I can build on main branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants