Prevent MissingWebViewPackageException #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capezzbr
commented
Jun 11, 2021
| private CookieSyncManager mCookieSyncManager; | ||
|
|
||
| CookieManagerModule(ReactApplicationContext context) { | ||
| super(context); | ||
| this.mCookieSyncManager = CookieSyncManager.createInstance(context); | ||
| this.mCookieManager = CookieManager.getInstance(); |
There was a problem hiding this comment.
Lazy get CookieManager instance - basically try to only crash when actually using the library
capezzbr
commented
Jun 11, 2021
| cookieManager.setAcceptCookie(true); | ||
| return cookieManager; | ||
| } catch (Exception e) { | ||
| throw new Exception(e); |
There was a problem hiding this comment.
Make it explicit that CookieManager.getInstance can throw
|
cc @safaiyeh 🙇 |
|
@capezzbr appreciate the PR! Let's get this deployed. |
safaiyeh
approved these changes
Jun 11, 2021
safaiyeh
pushed a commit
that referenced
this pull request
Jun 11, 2021
## [6.0.8](v6.0.7...v6.0.8) (2021-06-11) ### Bug Fixes * **Android:** Prevent MissingWebViewPackageException ([#119](#119)) ([645f218](645f218))
|
🎉 This PR is included in version 6.0.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
When
com.google.android.webviewis not found by the OS,Fatal Exception: android.util.AndroidRuntimeException: android.webkit.WebViewFactory$MissingWebViewPackageException: Failed to load WebView provider: No WebView installedis throw crashing the app.This PR prevents
@react-native-cookies/cookiesfrom throwing such exception, preventing the app from crashingHow to reproduce the crash
How does the PR work
This PR postpone accessing the
CookieManagerinstance (which could throwMissingWebViewPackageException) until when it's necessary, instead of doing when the native module is initialized.