Skip to content

Commit b3a996f

Browse files
cortinicofacebook-github-bot
authored andcommitted
Make sure template is consuming the right buildToolsVersion (#39956)
Summary: Currently, the template has a `buildToolsVersion = '34.0.0'` specified in the top level .gradle file but it's not currently using it. This is causing the build to fallback to the default version provided by AGP which is 33.x This is also causing the CI to download buildtools 34.0.0 as they're not in the container (causing network flakyness). I'm also bumping the docker container to v12 as we bumped NDK 26 which is missing in the v11 container. ## Changelog: [INTERNAL] [FIXED] - Make sure template is consuming the right buildToolsVersion Pull Request resolved: facebook/react-native#39956 Test Plan: CI should be green Reviewed By: christophpurrer Differential Revision: D50019777 Pulled By: cortinico fbshipit-source-id: a2ab7a7bd7c55624d5c050b45e69086c5f25ba6a Original-Commit: facebook/react-native@a5d5ead
1 parent 3f7c24c commit b3a996f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

template/template/android/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ def jscFlavor = 'org.webkit:android-jsc:+'
7171

7272
android {
7373
ndkVersion rootProject.ext.ndkVersion
74-
74+
buildToolsVersion rootProject.ext.buildToolsVersion
7575
compileSdk rootProject.ext.compileSdkVersion
7676

7777
namespace "com.helloworld"

0 commit comments

Comments
 (0)