[WIP] Fix android subtitle issue caused by using rawdatasource #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reime005 I see you've got a WIP tag on this and don't want to test / merge until you give the go ahead. Do you want to do any more testing before I test and merge this? |
|
I've tested this a lot in the last days, so you can test and merge this PR |
|
Works great! Thanks so much for tracking this down and fixing it. |
beauner69
pushed a commit
to beauner69/react-native-video
that referenced
this pull request
Oct 10, 2019
…e-fix [WIP] Fix android subtitle issue caused by using rawdatasource (rebased from commit 7837c39)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could reproduce the issue described in #1371 and fixed the issue. I'm not sure if this breaks some other functionality.
When testing, I received the following error message:
Tested on Android Emulator API 28 and 18. Release and Debug builds.
Project used: https://github.com/reime005/VideoPlayerTest
Fixes issue #1371