Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

0.58.5 Discussion #95

Closed
kelset opened this issue Feb 20, 2019 · 19 comments
Closed

0.58.5 Discussion #95

kelset opened this issue Feb 20, 2019 · 19 comments
Labels
backport request Cherry picking a change into an existing release stable Stable version

Comments

@kelset
Copy link
Member

kelset commented Feb 20, 2019

Conversation on this thread are limited to 0.58.5 release's major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.58.5 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in https://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.58-stable branch yourself, in order to ensure that the process proceeds smoothly.

@kelset kelset added stable Stable version backport request Cherry picking a change into an existing release labels Feb 20, 2019
@nihar108

This comment has been minimized.

@mikehardy

This comment has been minimized.

@nihar108

This comment has been minimized.

@mikehardy

This comment has been minimized.

@Bardiamist
Copy link
Contributor

Bardiamist commented Feb 20, 2019

I updated from 0.58.4 to 0.58.5 today and now I have warning when call fetch with saga.
Warning: somthing about n.slice on next code: yield call(fetch, 'apiUrl', requestOprions). But it works properly.
Works wothout warning: await fetch('apiUrl', requestOprions)
May be in future will create issue when will understand what the right place for this.
Can't make to reproduce demo because expo snack not using [email protected] now.

@dmainas
Copy link

dmainas commented Feb 20, 2019

Fix Inverted Horizontal ScrollView on Android facebook/react-native@32cb9ec

@thientnc-ibl
Copy link

thientnc-ibl commented Feb 21, 2019

Map TextInput textContentType strings to Objective-C constants facebook/react-native@a89fe41

@sunnylqm
Copy link
Contributor

Please cherry pick:
facebook/react-native@d9489c4

@lorenc-tomasz

This comment has been minimized.

@Bardiamist

This comment has been minimized.

@grabbou
Copy link
Member

grabbou commented Feb 25, 2019

@mikehardy I wouldn't say it better!

It's not the first time the ReactActivity commit comes up @nihar108, but given it's breaking and not trivial to merge, we decided to keep it for the 0.59 RC.

@lorenc-tomasz there's nothing to do to upgrade in between patch releases rather than just bumping your package.json.

@grabbou
Copy link
Member

grabbou commented Feb 27, 2019

I've been working on 0.59.0-rc.3 today and some fixes to the CLI. I am going to work on 0.58.6 tomorrow.

@fungilation
Copy link

Any rough estimate of when for 0.59.0 release?

@grabbou
Copy link
Member

grabbou commented Feb 28, 2019 via email

@PareshPatel721

This comment has been minimized.

@Bardiamist

This comment has been minimized.

@kelset

This comment has been minimized.

@grabbou
Copy link
Member

grabbou commented Feb 28, 2019

Cherry-picked commits, pushed to the CI to test if it's all green. I am half-way done with manual checks on RNTester and react-native init'ed app - will resume to this in few hours.

@kelset
Copy link
Member Author

kelset commented Feb 28, 2019

0.58.6 is out - thanks everyone!
New issue #97

@kelset kelset closed this as completed Feb 28, 2019
@react-native-community react-native-community locked as resolved and limited conversation to collaborators Feb 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport request Cherry picking a change into an existing release stable Stable version
Projects
None yet
Development

No branches or pull requests