Implement opacity prop for MapOverlay on Android and iOS (Google Maps) #3163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For some reason this property was disabled on Android.
- Transparency was not yet supported in the current google maps implementation, but supported by the google maps API.
|
LGTM I don't really get why travis is "yellow" the job seems to be executed with no error 😒 |
christopherdro
approved these changes
Mar 4, 2020
|
@JJStoker thanks for the PR 😻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
No.
What issue is this PR fixing?
We needed the ability to control the transparency/opacity of Overlay components. For some reason, the transparency control for GroundOverlay was commented out for Android and was never implemented for iOS.
The
transparencyoption was implemented asopacityas the rest of this project seems to preferopacity, and both platforms implemented it differently as well.How did you test this PR?
Tested on an android emulator and iOS simulator using
[email protected]and using the branch HEAD"react-native-maps": "git://github.com/Crop-R/react-native-maps.git#5ee80e8d1e5af9962937d5db578d333fef4d35cb"as a dependency. We pass an image url to theimageprop ofMapView.Overlay.