Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement 'tappable' prop on polyline for Android #2682

Merged
merged 2 commits into from
Feb 3, 2019
Merged

Implement 'tappable' prop on polyline for Android #2682

merged 2 commits into from
Feb 3, 2019

Conversation

techieyann
Copy link
Contributor

@techieyann techieyann commented Jan 30, 2019 •
edited
Loading

Does any other open PR do the same thing?

No

What issue is this PR fixing?

Fixes #2591

How did you test this PR?

  1. Create a Polyline and tap on it on Android.
  2. Observe onPress event from Map.
  3. Add tappable prop to Polyline.
  4. Observe lack of onPress event from Map.

@christopherdro christopherdro merged commit 122d4d3 into react-native-maps:master Feb 3, 2019
@adamwlev adamwlev mentioned this pull request Oct 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherdro christopherdro christopherdro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tappable Polyline (android)
2 participants
@techieyann @christopherdro