Add compass location offsets for iOS maps #2397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's please merge this into master as soon possible! |
|
Will be v useful |
|
Could this be merged in to master? Very helpful feature 🌟 |
christopherdro
approved these changes
Apr 14, 2019
|
@lijason103 any chance to fix the conflict so we can merge ? ❤️ |
|
@rborn fixed |
pohnean
pushed a commit
to pohnean/react-native-maps
that referenced
this pull request
Jul 28, 2020
* Added compass offset for iOS * Fixed import type * Updated doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
No.
What issue is this PR fixing?
Adding compass x and y offsets in iOS maps to allow repositioning stock compass
#576
How did you test this PR?
-Followed doc format.
-iOS simulator
-Apple Maps