Update the Google Maps custom map style if changed after initialization #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s been initialized.
mauritsd
force-pushed
the
dynamic-map-style
branch
from
d154fe8
to
90f01fb
Compare
|
@mauritsd thanks for the PR |
|
By that I meant that I didn't test it on Android as the app that required this bit of functionality is iOS-only. On iOS everything works as expected. I'll see if I can add it to the example. |
|
Did you test both apple and google maps? 🤓 |
|
@mauritsd any update in this? 🤗 |
|
LGTM (except the outdated |
|
@alvelig @christopherdro 🐽 how about this one? |
|
LGTM |
pohnean
pushed a commit
to pohnean/react-native-maps
that referenced
this pull request
Jul 28, 2020
…s been initialized. (react-native-maps#2017)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the library would not pass on the updated style to native Google Maps if a change occurred after onMapReady had fired. The native side doesn't seem to mind this happening, although I did not test extensively.