This repository has been archived by the owner on Jun 16, 2023. It is now read-only.
fix status for non authorized/pending camera #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sibelius
approved these changes
May 7, 2018
|
@sibelius Done. Please feel free to merge after CI passes 😊 |
sibelius
reviewed
May 7, 2018
| @@ -102,6 +102,12 @@ type StateType = { | |||
|
|
|||
| type Status = 'READY' | 'PENDING_AUTHORIZATION' | 'NOT_AUTHORIZED'; | |||
|
|
|||
| const CameraStatus = { | |||
There was a problem hiding this comment.
export this so end user can use it as well
There was a problem hiding this comment.
It is exported on RNCamera.Constants
jgfidelis
approved these changes
May 7, 2018
|
Please not merge yet. I think I made a mistake |
|
I was going to comment that naming was not making much sense hehe. Can we merge it? |
sibelius
approved these changes
May 7, 2018
|
@jgfidelis Feel free to merge 😉 |
Fconstant
pushed a commit
that referenced
this pull request
May 7, 2018
Fconstant
pushed a commit
that referenced
this pull request
May 7, 2018
Fconstant
added a commit
that referenced
this pull request
May 7, 2018
timxyz
pushed a commit
to 3sidedcube/react-native-camera
that referenced
this pull request
May 15, 2018
* master: (355 commits) UPDATED renderChildren to return this.props.children instead of null feat(types): add types for react-native-camera#1547 (react-native-camera#1548) fix(rn-camera): inject correct status feat(rn-camera): use and export constants fix status for non authorized/pending camera The correct capture preset for photos is AVCaptureSessionPresetPhoto add gradle 3 on issue template feat(types): add types for react-native-camera#1523 feat(types): add types for react-native-camera#1518 (FaCC) Add missing infer annotation dependency. fix(cache): store video recordings in same directory as photos fix(rn_camera): improve naming feat(rn_camera): add function as children 1.1.2 build(change-log): v1.1.2-4 FIXED warning for focusDepth on front-facing camera chore(cameraview): integrate google's cameraview directly on rncamera? fix(search-paths): remove unnecessary search paths and add missing one 1.1.1 build(change-log): v1.1.1-3 ... # Conflicts: # ios/RCTCameraManager.m
rad182
added a commit
to rad182/react-native-camera
that referenced
this pull request
May 18, 2018
* upstream/master: (23 commits) Updates Pod Install Instructions reenable camera on android emulator Create GradleUpgradeGuide.md Android: Fix java.lang.ArrayIndexOutOfBoundsException with image rotation Fix run time error missing facebook infer annotation UPDATED renderChildren to return this.props.children instead of null feat(types): add types for react-native-camera#1547 (react-native-camera#1548) fix(rn-camera): inject correct status feat(rn-camera): use and export constants fix status for non authorized/pending camera The correct capture preset for photos is AVCaptureSessionPresetPhoto add gradle 3 on issue template feat(types): add types for react-native-camera#1523 feat(types): add types for react-native-camera#1518 (FaCC) Add missing infer annotation dependency. fix(cache): store video recordings in same directory as photos fix(rn_camera): improve naming feat(rn_camera): add function as children 1.1.2 build(change-log): v1.1.2-4 ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.