Skip to content
This repository has been archived by the owner on Jun 16, 2023. It is now read-only.

Adds bounds to barcodeReadEvent #1402

Merged
merged 1 commit into from
Mar 27, 2018

Conversation

SimonErm
Copy link
Collaborator

#1307
Adds bounds to barcodeReadEvent. Tested on Android and iOs. Same behaviour like the old bounds:
on iOS:

bounds:{
  size:{
     width:string,
     height:string
  }
  origin:{
     x:string,
     y:string
}}

onAndroid:
bounds:[{x:string,y:string}]
on Android it returns just resultPoints:
for barcodes:
bounds[0].x : left side of barcode.
bounds[1].x : right side of barcode
counting for QRcodes:
1 2
0

@sibelius sibelius merged commit 5d30477 into react-native-camera:master Mar 27, 2018
@SimonErm SimonErm deleted the feature/barcodeBounds branch March 27, 2018 19:45
@Fconstant
Copy link
Collaborator

Oh I've seen that you already added the type defs. Good job 😁

@Fconstant
Copy link
Collaborator

Fconstant commented Mar 28, 2018

Oh, there's a flaw: [ { x: string, y: string } ] can only have length of 1.

@Fconstant
Copy link
Collaborator

Fconstant commented Mar 28, 2018

Also, this should be specified at the docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants