fix(warnings): remove inline styles

react-native-camera · Apr 15, 2018 · 716c4e3 · 716c4e3
1 parent 00f4f4c
commit 716c4e3
Show file tree

Hide file tree

Showing 3 changed files with 6,416 additions and 44 deletions.
diff --git a/src/Camera.js b/src/Camera.js
@@ -135,31 +135,12 @@ export default class Camera extends Component {
     permissionDialogTitle: '',
     permissionDialogMessage: '',
     notAuthorizedView: (
-      <View
-        style={{
-          flex: 1,
-          alignItems: 'center',
-          justifyContent: 'center',
-        }}
-      >
-        <Text
-          style={{
-            textAlign: 'center',
-            fontSize: 16,
-          }}
-        >
-          Camera not authorized
-        </Text>
+      <View style={styles.authorizationContainer}>
+        <Text style={styles.notAuthorizedText}>Camera not authorized</Text>
       </View>
     ),
     pendingAuthorizationView: (
-      <View
-        style={{
-          flex: 1,
-          alignItems: 'center',
-          justifyContent: 'center',
-        }}
-      >
+      <View style={styles.authorizationContainer}>
         <ActivityIndicator size="small" />
       </View>
     ),
@@ -403,4 +384,13 @@ const RCTCamera = requireNativeComponent('RCTCamera', Camera, {
 
 const styles = StyleSheet.create({
   base: {},
+  authorizationContainer: {
+    flex: 1,
+    alignItems: 'center',
+    justifyContent: 'center',
+  },
+  notAuthorizedText: {
+    textAlign: 'center',
+    fontSize: 16,
+  },
 });
diff --git a/src/RNCamera.js b/src/RNCamera.js
@@ -11,6 +11,7 @@ import {
   View,
   ActivityIndicator,
   Text,
+  StyleSheet,
 } from 'react-native';
 
 import type { FaceFeature } from './FaceDetector';
@@ -189,31 +190,12 @@ export default class Camera extends React.Component<PropsType, StateType> {
     permissionDialogTitle: '',
     permissionDialogMessage: '',
     notAuthorizedView: (
-      <View
-        style={{
-          flex: 1,
-          alignItems: 'center',
-          justifyContent: 'center',
-        }}
-      >
-        <Text
-          style={{
-            textAlign: 'center',
-            fontSize: 16,
-          }}
-        >
-          Camera not authorized
-        </Text>
+      <View style={styles.authorizationContainer}>
+        <Text style={styles.notAuthorizedText}>Camera not authorized</Text>
       </View>
     ),
     pendingAuthorizationView: (
-      <View
-        style={{
-          flex: 1,
-          alignItems: 'center',
-          justifyContent: 'center',
-        }}
-      >
+      <View style={styles.authorizationContainer}>
         <ActivityIndicator size="small" />
       </View>
     ),
@@ -405,3 +387,15 @@ const RNCamera = requireNativeComponent('RNCamera', Camera, {
     testID: true,
   },
 });
+
+const styles = StyleSheet.create({
+  authorizationContainer: {
+    flex: 1,
+    alignItems: 'center',
+    justifyContent: 'center',
+  },
+  notAuthorizedText: {
+    textAlign: 'center',
+    fontSize: 16,
+  },
+});