publish image on release #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dulmandakh
force-pushed
the
publish-release
branch
4 times, most recently
from
cd4d9e4 to
ee12999
Compare
Contributor
Author
|
@gengjiawen please merge 👍 |
Member
|
Can you keep the config.yml and js file in this PR. I would like keep them for a while. |
dulmandakh
force-pushed
the
publish-release
branch
2 times, most recently
from
2431a97 to
4a21524
Compare
dulmandakh
force-pushed
the
publish-release
branch
from
fbbb831 to
4d81fc1
Compare
Contributor
Author
|
@gengjiawen done, renamed .circleci/config.yaml so that it don't run in parallel with GitHub Actions. |
Member
|
Also avd test looks like not added to github action. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's publish docker image to Docker Hub if a GitHub release created, and have release notes attached to it. I updated publish.yaml to use v2 of build-push-action, and publish image with latest and GITHUB_REF, release tag reference, tags. Please publish a release once this merged.
Also build and test docker image only if Dockerfile changed.