Install both JDK 11 and 17 #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Member
Author
|
@gengjiawen this is ready for review 👍 |
Member
Author
|
@gengjiawen I'm merging this as the CI is currently red on RN's end because of #202 We can get back to this and tweak it afterwards if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on AGP 8.x bump for React Native.
We're currently having a harder time on bumping JDK to 17 for the whole project due to how we do testing (Mockito/PowerMock, etc.)
For the time being, we'll settle on running ReactAndroid on JDK 11, and app projects on JDK 17. Therefore we need both on the container