fix: Ignore case in validatePackageName (#1660)

* Ignore case in validatePackageName

Currently `validatePackageName` fails for package names containing uppercase letters. A message like this is shown during pod install:
```
warn Invalid application's package name "com.lugg.ReactNativeConfig" in 'AndroidManifest.xml'. Read guidelines for setting the package name here: https://developer.android.com/studio/build/application-id
warn Invalid application's package name "com.BV.LinearGradient" in 'AndroidManifest.xml'. Read guidelines for setting the package name here: https://developer.android.com/studio/build/application-id
warn Invalid application's package name "com.lugg.ReactNativeConfig" in 'AndroidManifest.xml'. Read guidelines for setting the package name here: https://developer.android.com/studio/build/application-id
warn Invalid application's package name "com.BV.LinearGradient" in 'AndroidManifest.xml'. Read guidelines for setting the package name here: https://developer.android.com/studio/build/application-id
```
 However both the package name (https://developer.android.com/guide/topics/manifest/manifest-element.html#package) and the application id (https://developer.android.com/studio/build/application-id) are allowed to contain upper case letters.

This change adds the "i" flag to the regex to ignore case when validating package name.

Related issue: facebook/react-native#34247

* Add tests for validatePackageName

Author: mlazari

packages/cli-platform-android/src/config/__tests__/getAndroidProject.test.ts

@@ -0,0 +1,36 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ */
+
+import {validatePackageName} from '../getAndroidProject';
+
+describe('android::getAndroidProject', () => {
+  const expectedResults = {
+    'com.app': true,
+    'com.example.app': true,
+    'com.my_app': true,
+    'org.my_app3': true,
+    'com.App': true,
+    'com.Example.APP1': true,
+    'COM.EXAMPLE.APP': true,
+    '': false,
+    com: false,
+    'com.3example.app': false,
+    'com.my_app*': false,
+    'org.my-app3': false,
+    'com.App ': false,
+    'com.Example.APP#1': false,
+  };
+
+  Object.keys(expectedResults).forEach((packageName) => {
+    it(`should validate package name "${packageName}" correctly`, () => {
+      expect(validatePackageName(packageName)).toBe(
+        expectedResults[packageName],
+      );
+    });
+  });
+});

packages/cli-platform-android/src/config/getAndroidProject.ts

@@ -47,6 +47,6 @@ export function getPackageName(manifestPath: string) {
 }
 
 // Validates that the package name is correct
-function validatePackageName(packageName: string) {
-  return /^[a-z][a-z0-9_]*(\.[a-z][a-z0-9_]*)+$/.test(packageName);
+export function validatePackageName(packageName: string) {
+  return /^[a-z][a-z0-9_]*(\.[a-z][a-z0-9_]*)+$/i.test(packageName);
 }