Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: multiGet accepts read-only array #803

Merged
merged 1 commit into from
May 9, 2022
Merged

fix: multiGet accepts read-only array #803

merged 1 commit into from
May 9, 2022

Conversation

maxhungry
Copy link
Contributor

@maxhungry maxhungry commented May 9, 2022 •
edited
Loading

Summary

Since getAllKeys returns readonly string[], it make sense for other functions to accept keys in readonly.

Error screenshot:

Screen Shot 2022-05-09 at 9 55 37 PM

Test Plan

TS compiles with no errors; tests are passing.

tido64
tido64 approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this ❤️

@tido64 tido64 enabled auto-merge (squash) May 9, 2022 10:04
@tido64 tido64 merged commit b044512 into react-native-async-storage:master May 9, 2022
@krizzu
Copy link
Member

krizzu commented May 9, 2022

🎉 This PR is included in version 1.17.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@krizzu krizzu added the released label May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tido64 tido64 tido64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxhungry @krizzu @tido64